Skip to content
This repository has been archived by the owner on Sep 27, 2022. It is now read-only.

No error handling #37

Open
anjmao opened this issue Jan 3, 2019 · 1 comment
Open

No error handling #37

anjmao opened this issue Jan 3, 2019 · 1 comment

Comments

@anjmao
Copy link

anjmao commented Jan 3, 2019

Hi,

Thanks for you work. I looked at the code and noticed that there is no proper error handling. Store methods are re-throwing in case of an error and nobody is handling that.

Example https://github.com/gothinkster/react-mobx-realworld-example-app/blob/master/src/stores/authStore.js#L42
In this case any Unsuccessful HTTP will cause Uncaught promise error.

@jcorkhill
Copy link

I don't see how this can be called a real-world example app without proper error handling, to be honest. MobX error handling patterns/practices is exactly what I'm looking for.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants