Skip to content

Commit fff89b8

Browse files
author
Stewart Miles
committed
Upgraded Android Resolver to gradle 4.10 and fixed some issues.
* Upgraded Android Resolver build and library downloader to Gradle 4.10 using `./gradlew wrapper --gradle-version 4.10`. * Added task to update the gradle wrapper in the Android Resolver. * Fixed support for dependency resolution when a transitive dependency is upgraded to a new version correctly by Gradle. * Updated test data for download_artifacts_test to specify valid version expressions for Gradle 4.x (Gradle 2.x was fine with them). * Improved reporting of conflicts by download_artifacts.gradle and increased verbosity of output by default. Tested: All integration tests are passing. Bug: 113343608 Change-Id: I8c5f43a9d251861cec3b0e80e1eb15fd71cd089b
1 parent 7d22470 commit fff89b8

File tree

17 files changed

+426
-221
lines changed

17 files changed

+426
-221
lines changed

build.gradle

+12-1
Original file line numberDiff line numberDiff line change
@@ -976,14 +976,25 @@ task testDownloadArtifacts(type: GradleBuild) {
976976
buildFile "source/PlayServicesResolver/scripts/download_artifacts_test.gradle"
977977
}
978978

979+
task updateEmbeddedGradleWrapper(type: Zip) {
980+
description "Update the gradle wrapper in gradle-template.zip"
981+
from project.ext.scriptDirectory
982+
include "gradlew"
983+
include "gradlew.bat"
984+
include "gradle/**"
985+
archiveName "gradle-template.zip"
986+
destinationDir (new File(project.ext.scriptDirectory,
987+
"source/PlayServicesResolver/scripts"))
988+
}
989+
979990
Task buildVersionHandler = createBuildPluginDllTask(
980991
"VersionHandler", "VersionHandler", "Google.VersionHandler.dll", false)
981992
Task buildVersionHandlerImpl = createBuildPluginDllTask(
982993
"VersionHandlerImpl", "VersionHandlerImpl", "Google.VersionHandlerImpl.dll",
983994
true, [buildVersionHandler])
984995
Task buildAndroidResolver = createBuildPluginDllTask(
985996
"AndroidResolver", "PlayServicesResolver", "Google.JarResolver.dll", true,
986-
[buildVersionHandlerImpl])
997+
[updateEmbeddedGradleWrapper, buildVersionHandlerImpl])
987998
Task buildIosResolver = createBuildPluginDllTask(
988999
"IosResolver", "IOSResolver", "Google.IOSResolver.dll", true,
9891000
[buildAndroidResolver])

gradle/wrapper/gradle-wrapper.jar

1.16 KB
Binary file not shown.
+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#Tue Dec 01 12:11:27 PST 2015
1+
#Tue Aug 28 14:18:05 PDT 2018
22
distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-2.14.1-all.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10-bin.zip

gradlew

+26-26
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,30 @@
66
##
77
##############################################################################
88

9-
# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
10-
DEFAULT_JVM_OPTS=""
9+
# Attempt to set APP_HOME
10+
# Resolve links: $0 may be a link
11+
PRG="$0"
12+
# Need this for relative symlinks.
13+
while [ -h "$PRG" ] ; do
14+
ls=`ls -ld "$PRG"`
15+
link=`expr "$ls" : '.*-> \(.*\)$'`
16+
if expr "$link" : '/.*' > /dev/null; then
17+
PRG="$link"
18+
else
19+
PRG=`dirname "$PRG"`"/$link"
20+
fi
21+
done
22+
SAVED="`pwd`"
23+
cd "`dirname \"$PRG\"`/" >/dev/null
24+
APP_HOME="`pwd -P`"
25+
cd "$SAVED" >/dev/null
1126

1227
APP_NAME="Gradle"
1328
APP_BASE_NAME=`basename "$0"`
1429

30+
# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
31+
DEFAULT_JVM_OPTS=""
32+
1533
# Use the maximum available, or set MAX_FD != -1 to use that value.
1634
MAX_FD="maximum"
1735

@@ -30,6 +48,7 @@ die ( ) {
3048
cygwin=false
3149
msys=false
3250
darwin=false
51+
nonstop=false
3352
case "`uname`" in
3453
CYGWIN* )
3554
cygwin=true
@@ -40,31 +59,11 @@ case "`uname`" in
4059
MINGW* )
4160
msys=true
4261
;;
62+
NONSTOP* )
63+
nonstop=true
64+
;;
4365
esac
4466

45-
# For Cygwin, ensure paths are in UNIX format before anything is touched.
46-
if $cygwin ; then
47-
[ -n "$JAVA_HOME" ] && JAVA_HOME=`cygpath --unix "$JAVA_HOME"`
48-
fi
49-
50-
# Attempt to set APP_HOME
51-
# Resolve links: $0 may be a link
52-
PRG="$0"
53-
# Need this for relative symlinks.
54-
while [ -h "$PRG" ] ; do
55-
ls=`ls -ld "$PRG"`
56-
link=`expr "$ls" : '.*-> \(.*\)$'`
57-
if expr "$link" : '/.*' > /dev/null; then
58-
PRG="$link"
59-
else
60-
PRG=`dirname "$PRG"`"/$link"
61-
fi
62-
done
63-
SAVED="`pwd`"
64-
cd "`dirname \"$PRG\"`/" >&-
65-
APP_HOME="`pwd -P`"
66-
cd "$SAVED" >&-
67-
6867
CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar
6968

7069
# Determine the Java command to use to start the JVM.
@@ -90,7 +89,7 @@ location of your Java installation."
9089
fi
9190

9291
# Increase the maximum file descriptors if we can.
93-
if [ "$cygwin" = "false" -a "$darwin" = "false" ] ; then
92+
if [ "$cygwin" = "false" -a "$darwin" = "false" -a "$nonstop" = "false" ] ; then
9493
MAX_FD_LIMIT=`ulimit -H -n`
9594
if [ $? -eq 0 ] ; then
9695
if [ "$MAX_FD" = "maximum" -o "$MAX_FD" = "max" ] ; then
@@ -114,6 +113,7 @@ fi
114113
if $cygwin ; then
115114
APP_HOME=`cygpath --path --mixed "$APP_HOME"`
116115
CLASSPATH=`cygpath --path --mixed "$CLASSPATH"`
116+
JAVACMD=`cygpath --unix "$JAVACMD"`
117117

118118
# We build the pattern for arguments to be converted via cygpath
119119
ROOTDIRSRAW=`find -L / -maxdepth 1 -mindepth 1 -type d 2>/dev/null`

gradlew.bat

+4-4
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@
88
@rem Set local scope for the variables with windows NT shell
99
if "%OS%"=="Windows_NT" setlocal
1010

11-
@rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
12-
set DEFAULT_JVM_OPTS=
13-
1411
set DIRNAME=%~dp0
1512
if "%DIRNAME%" == "" set DIRNAME=.
1613
set APP_BASE_NAME=%~n0
1714
set APP_HOME=%DIRNAME%
1815

16+
@rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
17+
set DEFAULT_JVM_OPTS=
18+
1919
@rem Find java.exe
2020
if defined JAVA_HOME goto findJavaFromJavaHome
2121

@@ -46,7 +46,7 @@ echo location of your Java installation.
4646
goto fail
4747

4848
:init
49-
@rem Get command-line arguments, handling Windowz variants
49+
@rem Get command-line arguments, handling Windows variants
5050

5151
if not "%OS%" == "Windows_NT" goto win9xME_args
5252
if "%@eval[2+2]" == "4" goto 4NT_args

0 commit comments

Comments
 (0)