Reduce hardcoded target name strings

Replace hardcoded target names like `Unity-iPhone` and `UnityFrameworks`
with properties.

Change-Id: Ieac0078aed70c66f6246971a0b7bdb6bd2ab50d9

Author: chkuang-g

source/IOSResolver/src/IOSResolver.cs

@@ -808,6 +808,29 @@ internal static bool MultipleXcodeTargetsSupported {
         }
     }
 
+    /// <summary>
+    /// Name of the Xcode main target generated by Unity.
+    /// </summary>
+    public static string XcodeMainTargetName {
+        get {
+            // NOTE: Unity-iPhone is hard coded in UnityEditor.iOS.Xcode.PBXProject and will no
+            // longer be exposed via GetUnityTargetName(). It hasn't changed in many years though
+            // so we'll use this constant as a relatively safe default.
+            return MultipleXcodeTargetsSupported ? "Unity-iPhone" :
+                (string)VersionHandler.InvokeStaticMethod(typeof(UnityEditor.iOS.Xcode.PBXProject),
+                                                          "GetUnityTargetName", null);
+        }
+    }
+
+    /// <summary>
+    /// Name of the Xcode UnityFramework target generated by Unity 2019.3+
+    /// </summary>
+    public static string XcodeUnityFrameworkTargetName {
+        get {
+            return "UnityFramework";
+        }
+    }
+
     /// <summary>
     /// Initialize the TARGET_NAME property.
     /// This will be "Unity-iPhone" in versions of Unity (2019.3+) that added support for using
@@ -818,9 +841,7 @@ private static string InitializeTargetName() {
         // NOTE: Unity-iPhone is hard coded in UnityEditor.iOS.Xcode.PBXProject and will soon longer
         // be exposed via GetUnityTargetName(). It hasn't changed in many years though so we'll use
         // this constant as a relatively safe default for users of the TARGET_NAME variable.
-        TARGET_NAME = MultipleXcodeTargetsSupported ? "Unity-iPhone" :
-            (string)VersionHandler.InvokeStaticMethod(typeof(UnityEditor.iOS.Xcode.PBXProject),
-                                                      "GetUnityTargetName", null);
+        TARGET_NAME = XcodeMainTargetName;
         return TARGET_NAME;
     }
 
@@ -1802,7 +1823,7 @@ public static IEnumerable<string> XcodeTargetNames {
         get {
             // Return hard coded names in the UnityEditor.iOS.Xcode.PBXProject DLL.
             return MultipleXcodeTargetsSupported ?
-                new List<string>() { "UnityFramework" } :
+                new List<string>() { XcodeUnityFrameworkTargetName } :
                 new List<string>() { InitializeTargetName() };
         }
     }
@@ -1954,7 +1975,7 @@ private static void ParseUnityDeps(string unityPodfilePath) {
                 continue;
             }
             // TODO: Properly support multiple targets.
-            if (line.StartsWith("target 'Unity-iPhone' do")) {
+            if (line.StartsWith(String.Format("target '{0}' do", XcodeMainTargetName))) {
                 capturingPodsDepth++;
                 continue;
             }
@@ -2074,7 +2095,7 @@ public static void GenPodfile(BuildTarget buildTarget,
             }
 
             if (MultipleXcodeTargetsSupported && PodfileAlwaysAddMainTarget) {
-                file.WriteLine(String.Format("target '{0}' do", "Unity-iPhone"));
+                file.WriteLine(String.Format("target '{0}' do", XcodeMainTargetName));
                 bool allowPodsInMultipleTargets = PodfileAllowPodsInMultipleTargets;
                 int podAdded = 0;
                 foreach(var pod in pods.Values) {

source/IOSResolver/src/IOSResolverSettingsDialog.cs

@@ -222,8 +222,8 @@ public void OnGUI() {
                 GUILayout.EndHorizontal();
 
                 GUILayout.Label("Add the following lines to Podfile.");
-                GUILayout.Label("  target 'Unity-iPhone' do\n" +
-                                "  end");
+                GUILayout.Label(String.Format("  target '{0}' do\n" +
+                                              "  end", IOSResolver.XcodeMainTargetName));
 
                 if (settings.podfileAlwaysAddMainTarget) {
                     GUILayout.BeginHorizontal();