Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arcs don't normalize well #415

Open
rsheeter opened this issue Apr 30, 2022 · 1 comment · May be fixed by #414
Open

Arcs don't normalize well #415

rsheeter opened this issue Apr 30, 2022 · 1 comment · May be fixed by #414
Assignees

Comments

@rsheeter
Copy link
Collaborator

Observed when testing emoji clock faces with nanoemoji part files:

    {
      "normalized": "M0,0 a60 60 0 1 1 1,0 a60 60 0 1 1 -1,0 z",
      "shapes": [
        "M124,64 A60 60 0 1 1 4,64 A60 60 0 1 1 124,64 Z"
      ]
    },
    {
      "normalized": "M0,0 a48.1 48.1 0 1 1 1,0 a48.1 48.1 0 1 1 -1,0 z",
      "shapes": [
        "M112.14,64 A48.14 48.14 0 1 1 15.86,64 A48.14 48.14 0 1 1 112.14,64 Z"
      ]
    },

image

@rsheeter
Copy link
Collaborator Author

rsheeter commented May 6, 2022

Interestingly fixing arc normalization doesn't alter the current implementation results for emoji, presumably because we hit arcs to cubics prior to reuse in the current model.

@rsheeter rsheeter linked a pull request May 6, 2022 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant