Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic README #1

Closed
Hoolean opened this issue Jan 20, 2025 · 10 comments
Closed

Add basic README #1

Hoolean opened this issue Jan 20, 2025 · 10 comments
Assignees

Comments

@Hoolean
Copy link
Collaborator

Hoolean commented Jan 20, 2025

No description provided.

@vv-monsalve
Copy link

vv-monsalve commented Feb 13, 2025

Hello @Hoolean,

Is the tool ready to be used with any font? I would like to use it to help determine the VM for Arabic and Devanagari fonts.

It would be really helpful to have installation and usage instructions in the Readme.

Thanks!

@Hoolean
Copy link
Collaborator Author

Hoolean commented Feb 14, 2025

@vv-monsalve Hi Viviana! Not yet unfortunately, we only have the skeleton here right now, but we're scheduled to pick up development again in the next couple of weeks :)

@vv-monsalve
Copy link

Awesome! :-)

@davelab6
Copy link
Member

@Hoolean I'd like to ask priorizing this as now the internal GF eng team needs it :) cc @chrissimpkins

@belluzj
Copy link
Collaborator

belluzj commented Feb 27, 2025

Hello @davelab6 , which part of the fontheight tool is needed in priority? We have plans for:

  • a CLI tool to report the vertical min/max from the command line
  • a FontBakery check that the Win metrics are large enough to encompass the vertical min/max
  • an HTML report with SVG pictures of shaped words that hit the lowest and highest points

@Hoolean FYI

@RickyDaMa
Copy link
Collaborator

I'll make sure the README is written once the tool is in a usable state - currently it's not usable by anyone unless they're also going to be hacking on the Rust code.

Of what's mentioned in Jany's message, we're currently prioritising the FontBakery check. There is a commandline tool version in-repo right now, though that's more for ease of testing as it doesn't produce useful information for end users currently

@davelab6
Copy link
Member

davelab6 commented Mar 3, 2025

I'm sorry I meant just the readme, I was sharing the tool internally and people asked "what is it" lol

Having a mission/vision statement in the readme about what it will be in future is ideal if it's not yet running at all

@davelab6
Copy link
Member

davelab6 commented Mar 3, 2025

Cli would be great to get running in a useful way before a check wrapper

@belluzj
Copy link
Collaborator

belluzj commented Mar 3, 2025

Makes sense, thanks for the clarifications!

@RickyDaMa RickyDaMa self-assigned this Mar 3, 2025
@RickyDaMa
Copy link
Collaborator

Added a basic explainer of why the tool exists and what it does (will do). Let me know if there's anything else you'd like me to add!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants