Skip to content

Commit 39c9b9e

Browse files
speedstorm1copybara-github
authored andcommitted
chore: update tests to be compatible with Python 3.14, set 3.14 testing workflow as required
PiperOrigin-RevId: 825273830
1 parent 741c6ad commit 39c9b9e

File tree

6 files changed

+31
-2
lines changed

6 files changed

+31
-2
lines changed

testing/constraints-3.14.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ ipython==8.22.2 # Pinned to unbreak TypeAliasType import error
1313
google-adk==0.0.2
1414
google-genai>=1.10.0
1515
google-vizier==0.1.21
16-
pyarrow>=18.0.0
16+
pyarrow>=22.0.0

tests/unit/aiplatform/test_prediction.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3287,7 +3287,10 @@ def test_health(self, model_server_env_mock, importlib_import_module_mock_twice)
32873287

32883288
assert response.status_code == 200
32893289

3290-
def test_predict(self, model_server_env_mock, importlib_import_module_mock_twice):
3290+
@pytest.mark.asyncio
3291+
async def test_predict(
3292+
self, model_server_env_mock, importlib_import_module_mock_twice
3293+
):
32913294
model_server = CprModelServer()
32923295
client = TestClient(model_server.app)
32933296

tests/unit/vertex_rag/test_rag_data.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -419,6 +419,11 @@ def create_transformation_config(
419419
def rag_corpus_eq(returned_corpus, expected_corpus):
420420
assert returned_corpus.name == expected_corpus.name
421421
assert returned_corpus.display_name == expected_corpus.display_name
422+
# assert returned_corpus.backend_config == expected_corpus.backend_config
423+
# assert (
424+
# returned_corpus.vertex_ai_search_config
425+
# == expected_corpus.vertex_ai_search_config
426+
# )
422427
assert returned_corpus.backend_config.__eq__(expected_corpus.backend_config)
423428
assert returned_corpus.vertex_ai_search_config.__eq__(
424429
expected_corpus.vertex_ai_search_config
@@ -464,6 +469,9 @@ def import_files_request_eq(returned_request, expected_request):
464469

465470
def rag_engine_config_eq(returned_config, expected_config):
466471
assert returned_config.name == expected_config.name
472+
# assert (
473+
# returned_config.rag_managed_db_config == expected_config.rag_managed_db_config
474+
# )
467475
assert returned_config.rag_managed_db_config.__eq__(
468476
expected_config.rag_managed_db_config
469477
)

tests/unit/vertex_rag/test_rag_data_preview.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -674,6 +674,13 @@ def create_transformation_config(
674674
def rag_corpus_eq(returned_corpus, expected_corpus):
675675
assert returned_corpus.name == expected_corpus.name
676676
assert returned_corpus.display_name == expected_corpus.display_name
677+
# assert returned_corpus.vector_db == expected_corpus.vector_db
678+
# assert returned_corpus.backend_config == expected_corpus.backend_config
679+
# assert (
680+
# returned_corpus.vertex_ai_search_config
681+
# == expected_corpus.vertex_ai_search_config
682+
# )
683+
# assert returned_corpus.corpus_type_config == expected_corpus.corpus_type_config
677684
assert returned_corpus.vector_db.__eq__(expected_corpus.vector_db)
678685
assert returned_corpus.backend_config.__eq__(expected_corpus.backend_config)
679686
assert returned_corpus.vertex_ai_search_config.__eq__(
@@ -729,6 +736,9 @@ def import_files_request_eq(returned_request, expected_request):
729736

730737
def rag_engine_config_eq(returned_config, expected_config):
731738
assert returned_config.name == expected_config.name
739+
# assert (
740+
# returned_config.rag_managed_db_config == expected_config.rag_managed_db_config
741+
# )
732742
assert returned_config.rag_managed_db_config.__eq__(
733743
expected_config.rag_managed_db_config
734744
)

vertexai/preview/rag/utils/_gapic_utils.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,8 @@ def convert_gapic_to_backend_config(
293293
gapic_vector_db: GapicRagVectorDbConfig,
294294
) -> RagVectorDbConfig:
295295
"""Convert Gapic RagVectorDbConfig to VertexVectorSearch, Pinecone, or RagManagedDb."""
296+
if not gapic_vector_db:
297+
return None
296298
vector_config = RagVectorDbConfig()
297299
if _check_pinecone(gapic_vector_db):
298300
vector_config.vector_db = Pinecone(
@@ -314,6 +316,8 @@ def convert_gapic_to_backend_config(
314316
gapic_vector_db.rag_embedding_model_config
315317
)
316318
)
319+
# if not vector_config.vector_db and not vector_config.rag_embedding_model_config:
320+
# return None
317321
return vector_config
318322

319323

vertexai/rag/utils/_gapic_utils.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,8 @@ def convert_gapic_to_backend_config(
175175
gapic_vector_db: GapicRagVectorDbConfig,
176176
) -> RagVectorDbConfig:
177177
"""Convert Gapic RagVectorDbConfig to VertexVectorSearch, Pinecone, or RagManagedDb."""
178+
if not gapic_vector_db:
179+
return None
178180
vector_config = RagVectorDbConfig()
179181
if _check_pinecone(gapic_vector_db):
180182
vector_config.vector_db = Pinecone(
@@ -194,6 +196,8 @@ def convert_gapic_to_backend_config(
194196
gapic_vector_db.rag_embedding_model_config
195197
)
196198
)
199+
# if not vector_config.vector_db and not vector_config.rag_embedding_model_config:
200+
# return None
197201
return vector_config
198202

199203

0 commit comments

Comments
 (0)