Skip to content

Commit b7898d2

Browse files
feat: allow flush level OFF (#319)
1 parent c0e02ba commit b7898d2

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

src/main/java/com/google/cloud/logging/logback/LoggingAppender.java

+4-1
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,10 @@ public synchronized void start() {
211211
MonitoredResource resource = getMonitoredResource(getProjectId());
212212
defaultWriteOptions =
213213
new WriteOption[] {WriteOption.logName(getLogName()), WriteOption.resource(resource)};
214-
getLogging().setFlushSeverity(severityFor(getFlushLevel()));
214+
Level flushLevel = getFlushLevel();
215+
if (flushLevel != Level.OFF) {
216+
getLogging().setFlushSeverity(severityFor(flushLevel));
217+
}
215218
loggingEnhancers = new ArrayList<>();
216219
List<LoggingEnhancer> resourceEnhancers = MonitoredResourceUtil.getResourceEnhancers();
217220
loggingEnhancers.addAll(resourceEnhancers);

src/test/java/com/google/cloud/logging/logback/LoggingAppenderTest.java

+8
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,14 @@ public void testFlushLevelConfigUpdatesLoggingFlushSeverity() {
112112
assertThat(capturedArgument.getValue().iterator().next()).isEqualTo(logEntry);
113113
}
114114

115+
@Test
116+
public void testFlushLevelConfigSupportsFlushLevelOff() {
117+
loggingAppender.setFlushLevel(Level.OFF);
118+
loggingAppender.start();
119+
Severity foundSeverity = logging.getFlushSeverity();
120+
assertThat(foundSeverity).isEqualTo(null);
121+
}
122+
115123
@Test
116124
public void testFilterLogsOnlyLogsAtOrAboveLogLevel() {
117125
Map<String, Object> jsonContent = new HashMap<>();

0 commit comments

Comments
 (0)