-
Notifications
You must be signed in to change notification settings - Fork 438
Closed
Labels
api: spannerIssues related to the Spanner API.Issues related to the Spanner API.next major: breaking changethis is a change that we should wait to bundle into the next major versionthis is a change that we should wait to bundle into the next major versiontype: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.
Description
As of 2022-06-01, google::cloud::spanner::MakeTestRow() has been deprecated in favor of the identically-functioning google::cloud::spanner_mocks::MakeRow().
This is part of an effort to move test-only code to test-only libraries.
The old interface will be removed from the code base on or shortly after 2023-06-01, so users will need to migrate any affected code before then. Deprecation attributes have been added to the old API to aid in its identification. See the diffs between the old and new calls in #9080 for a more concise picture of how to perform migrations.
When the deprecation period expires we should:
- move the implementation to
spanner_mocks::MakeRow(), replacing the forwarding calls, and remove thedisable_deprecation_warningswrapping, and - remove
spanner::MakeTestRow()and itsGOOGLE_CLOUD_CPP_SPANNER_MAKE_TEST_ROW_DEPRECATED()attribute macro.
Metadata
Metadata
Assignees
Labels
api: spannerIssues related to the Spanner API.Issues related to the Spanner API.next major: breaking changethis is a change that we should wait to bundle into the next major versionthis is a change that we should wait to bundle into the next major versiontype: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.