Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluate refactor builder patterns so that setters do not need to be override in child classes. #1541

Open
zhumin8 opened this issue Oct 17, 2024 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@zhumin8
Copy link
Contributor

zhumin8 commented Oct 17, 2024

see this comment for context: #1528 (comment)

builders are not created with generic types across this repo e.g.

public static class Builder extends OAuth2Credentials.Builder {

This means to allow customer code to use a fluent builder API without casting, setters in parent classes need to be overriden in child classes, even without adding specific logics.

Note that adding generics to existing classes may also produce warning regarding raw use of generic types.

@zhumin8 zhumin8 added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

1 participant