Skip to content

Readme and documentation differ on require example #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcospgp opened this issue Mar 13, 2018 · 2 comments
Closed

Readme and documentation differ on require example #1063

marcospgp opened this issue Mar 13, 2018 · 2 comments
Assignees

Comments

@marcospgp
Copy link

On the http://google.github.io documentation pages this way of requesting the library is given:

const google = require('googleapis'); const tagmanager = google.tagmanager('v2');

I found this didn't work, and went confirm that this was the same on the readme. I found that it differs slightly:

var {google} = require('googleapis'); var urlshortener = google.urlshortener('v1');

Interestingly, the use of const is more modern than var, but the example with var is the one that works 😄

It would be a good idea to update the http://google.github.io pages.

Thanks!

@marcospgp marcospgp changed the title Readme and documentation differs on require example Readme and documentation differ on require example Mar 13, 2018
@JustinBeckwith
Copy link
Contributor

Apologies for the troubles here! The docs on http://google.github.io are wildly out of date. To get them updated, we need to complete a few things around the TypeScript transition.

This is blocked by:

In the meantime, I submitted #1084 to help clean up some of the old code in the README :)

@JustinBeckwith
Copy link
Contributor

Greetings! This is now fixed 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants