Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Debug+Display, not Error #207

Open
Manishearth opened this issue Jul 22, 2021 · 4 comments
Open

Require Debug+Display, not Error #207

Manishearth opened this issue Jul 22, 2021 · 4 comments

Comments

@Manishearth
Copy link
Collaborator

In ICU4X we're moving towards no_std support, and this means that by default the Error trait is not implemented. It's possible to explicitly enable the "std" feature and have it be enabled, however it seems like it's unnecessary to require Error on the error associated types since none of Errors functionality is actually used — perhaps we should just require Debug+Display, or maybe even just one or none of those traits. In general we should require the traits we need.
@Manishearth Manishearth mentioned this issue Jul 22, 2021
Merged
@filmil
Copy link
Member

filmil commented Aug 13, 2021

Agreed in principle. Does someone need this these days?

@Manishearth
Copy link
Collaborator Author

Need what exactly?

@filmil
Copy link
Member

filmil commented Aug 13, 2021

What I meant is, is someone at the moment blocked on the use of Error in rust_icu, and would be helped by using Debug+Display instead?

@Manishearth
Copy link
Collaborator Author

It means that our ecma402 bindings need std to compile, seems like a very minor reason to not be no_std

unicode-org/icu4x#888 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@filmil @Manishearth