Skip to content

Commit 793ba74

Browse files
committed
fixup: review comments
1 parent 1e34ea7 commit 793ba74

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

ecma402_traits/src/datetimeformat.rs

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,14 @@ pub mod options {
6767
}
6868
}
6969

70-
/// The way day periods should be expressed.
70+
/// The way day periods (morning, afternoon) should be expressed.
7171
#[derive(Eq, PartialEq, Debug, Clone)]
7272
pub enum DayPeriod {
73+
/// "AM", "PM"
7374
Narrow,
75+
/// "A.M.", "P.M".
7476
Short,
77+
/// "Morning", "Afternoon".
7578
Long,
7679
}
7780

@@ -81,8 +84,7 @@ pub mod options {
8184
/// "guru", "hanidec", "khmr", " knda", "laoo", "latn", "limb", "mlym", " mong", "mymr",
8285
/// "orya", "tamldec", " telu", "thai", "tibt".
8386
///
84-
/// The value entered as currency is not validated. This responsibility is
85-
/// delegated to the implementor.
87+
/// The value entered is not validated. This responsibility is delegated to the implementor.
8688
#[derive(Eq, PartialEq, Debug, Clone)]
8789
pub struct NumberingSystem(pub String);
8890

@@ -100,8 +102,7 @@ pub mod options {
100102

101103
/// Controls the time zone formatting.
102104
///
103-
/// The value entered as currency is not validated. This responsibility is
104-
/// delegated to the implementor.
105+
/// The value entered is not validated. This responsibility is delegated to the implementor.
105106
#[derive(Eq, PartialEq, Debug, Clone)]
106107
pub struct TimeZone(pub String);
107108

@@ -172,8 +173,13 @@ pub mod options {
172173
Narrow,
173174
}
174175

176+
/// The time zone name styling to use.
175177
#[derive(Eq, PartialEq, Debug, Clone)]
176178
pub enum TimeZoneStyle {
179+
/// "British Summer Time"
180+
Long,
181+
/// "GMT+1"
182+
Short,
177183
}
178184
}
179185

0 commit comments

Comments
 (0)