Skip to content

Commit c50bd32

Browse files
taku910hiroyuki-komatsu
authored andcommitted
Changes the default values of literal on top parameters.
We confiremed that following two parameters have no positive but negative impact so set default values (0) to turn off these features. typing_correction_literal_on_top_conversion_cost_max_diff typing_correction_literal_on_top_correction_score_max_diff typing_correction_literal_at_least_second are enabled both in canary and production, so we change the default value. PiperOrigin-RevId: 627983164
1 parent f1a0f52 commit c50bd32

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/data/test/session/scenario/b7321313_scenario.txt

+2-4
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ SEND_KEY RIGHT
1919
SEND_KEYS 44444111
2020

2121
# The result should be "鉄道" for now.
22-
# TODO(taku): change the default param so literal-on-top stops working.
23-
EXPECT_CANDIDATE 1 鉄道
22+
EXPECT_CANDIDATE 0 鉄道
2423

2524
# Move the caret to the beginnig, and back to the end.
2625
SEND_KEY LEFT
@@ -31,5 +30,4 @@ SEND_KEY RIGHT
3130
SEND_KEY RIGHT
3231

3332
# The candidate is still "鉄道"
34-
# TODO(taku): change the default param so literal-on-top stops working.
35-
EXPECT_CANDIDATE 1 鉄道
33+
EXPECT_CANDIDATE 0 鉄道

src/protocol/commands.proto

+2-2
Original file line numberDiff line numberDiff line change
@@ -626,9 +626,9 @@ message DecoderExperimentParams {
626626
// typing_correction_literal_on_top_length_score_max_diff
627627
// * (typing_correction_literal_on_top_length_decay^(input_length-3))
628628
optional float typing_correction_literal_on_top_correction_score_max_diff = 47
629-
[default = 0.5];
629+
[default = 0.0];
630630
optional int32 typing_correction_literal_on_top_conversion_cost_max_diff = 48
631-
[default = 2000];
631+
[default = 0];
632632
// Literal candidate is placed at least second position.
633633
optional bool typing_correction_literal_at_least_second = 49
634634
[default = false];

0 commit comments

Comments
 (0)