Skip to content

Commit 7233d7b

Browse files
Noriyuki Takahashihiroyuki-komatsu
Noriyuki Takahashi
authored andcommitted
Use the supplemental model in converter_main.
Now the rescorer is managed by the supplemental model, we can use it. PiperOrigin-RevId: 634578253
1 parent cec685a commit 7233d7b

File tree

5 files changed

+7
-13
lines changed

5 files changed

+7
-13
lines changed

Diff for: src/converter/BUILD.bazel

+5-2
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ load(
3333
"mozc_cc_library",
3434
"mozc_cc_test",
3535
"mozc_py_binary",
36-
"mozc_select_enable_neural_language_model",
3736
"mozc_select_enable_supplemental_model",
3837
)
3938
load("//bazel:stubs.bzl", "bzl_library")
@@ -568,8 +567,10 @@ mozc_cc_binary(
568567
"//data_manager",
569568
"//engine",
570569
"//engine:engine_interface",
570+
"//engine:supplemental_model_interface",
571571
"//protocol:commands_cc_proto",
572572
"//protocol:config_cc_proto",
573+
"//protocol:engine_builder_cc_proto",
573574
"//request:conversion_request",
574575
"//request:request_test_util",
575576
"@com_google_absl//absl/flags:flag",
@@ -578,7 +579,9 @@ mozc_cc_binary(
578579
"@com_google_absl//absl/status:statusor",
579580
"@com_google_absl//absl/strings",
580581
"@com_google_absl//absl/strings:str_format",
581-
] + mozc_select_enable_neural_language_model([
582+
] + mozc_select_enable_supplemental_model([
583+
"//supplemental_model:supplemental_model_factory",
584+
"//supplemental_model:supplemental_model_registration",
582585
]),
583586
)
584587

Diff for: src/converter/converter_main.cc

+2
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,10 @@
6464
#include "data_manager/data_manager.h"
6565
#include "engine/engine.h"
6666
#include "engine/engine_interface.h"
67+
#include "engine/supplemental_model_interface.h"
6768
#include "protocol/commands.pb.h"
6869
#include "protocol/config.pb.h"
70+
#include "protocol/engine_builder.pb.h"
6971
#include "request/conversion_request.h"
7072
#include "request/request_test_util.h"
7173

Diff for: src/engine/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,6 @@ mozc_cc_library(
185185
"//prediction:dictionary_predictor",
186186
"//prediction:predictor",
187187
"//prediction:predictor_interface",
188-
"//prediction:rescorer_interface",
189188
"//prediction:user_history_predictor",
190189
"//protocol:engine_builder_cc_proto",
191190
"//rewriter",

Diff for: src/engine/engine.h

-6
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@
5252
#include "engine/supplemental_model_interface.h"
5353
#include "engine/user_data_manager_interface.h"
5454
#include "prediction/predictor_interface.h"
55-
#include "prediction/rescorer_interface.h"
5655
#include "rewriter/rewriter_interface.h"
5756

5857
namespace mozc {
@@ -148,11 +147,6 @@ class Engine : public EngineInterface {
148147
modules_->SetSupplementalModel(supplemental_model);
149148
}
150149

151-
void SetRescorer(
152-
std::unique_ptr<const prediction::RescorerInterface> rescorer) override {
153-
modules_->SetRescorer(std::move(rescorer));
154-
}
155-
156150
// For testing only.
157151
engine::Modules *GetModulesForTesting() const { return modules_.get(); }
158152

Diff for: src/engine/modules.h

-4
Original file line numberDiff line numberDiff line change
@@ -118,10 +118,6 @@ class Modules {
118118
const prediction::RescorerInterface *GetRescorer() const {
119119
return rescorer_.get();
120120
}
121-
void SetRescorer(
122-
std::unique_ptr<const prediction::RescorerInterface> rescorer) {
123-
rescorer_ = std::move(rescorer);
124-
}
125121

126122

127123
const engine::SupplementalModelInterface *GetSupplementalModel() const {

0 commit comments

Comments
 (0)