Skip to content

Commit bc155cb

Browse files
committed
revert type change to withContent
1 parent 860bc7a commit bc155cb

File tree

8 files changed

+17
-16
lines changed

8 files changed

+17
-16
lines changed

.github/workflows/dart.yml

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

mono_repo/lib/src/commands/github/action_info.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ enum ActionInfo implements Comparable<ActionInfo> {
5353
Step usage({
5454
String? name,
5555
String? id,
56-
Map<String, String>? withContent,
56+
Map<String, dynamic>? withContent,
5757
}) {
5858
name ??= this.name;
5959
final step = Step.uses(
@@ -80,7 +80,7 @@ Job _coverageCompletionJob() => Job(
8080
withContent: {
8181
// https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow
8282
'github-token': r'${{ secrets.GITHUB_TOKEN }}',
83-
'parallel-finished': 'true'
83+
'parallel-finished': true
8484
},
8585
)
8686
],

mono_repo/lib/src/commands/github/github_yaml.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ class _CommandEntry extends _CommandEntryBase implements GitHubActionOverrides {
462462
final Map<String, String>? env;
463463

464464
@override
465-
final Map<String, String>? withContent;
465+
final Map<String, dynamic>? withContent;
466466

467467
@override
468468
final String? shell;

mono_repo/lib/src/commands/github/overrides.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ abstract class GitHubActionOverrides {
2020
///
2121
/// A map of key-value pairs which are passed to the action's `with`
2222
/// parameter.
23-
Map<String, String>? get withContent;
23+
Map<String, dynamic>? get withContent;
2424

2525
/// The condition on which to run this action.
2626
String? get ifContent;

mono_repo/lib/src/commands/github/step.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class Step implements GitHubActionOverrides, YamlLike {
3737
final String? uses;
3838
@override
3939
@JsonKey(name: 'with')
40-
final Map<String, String>? withContent;
40+
final Map<String, dynamic>? withContent;
4141

4242
@override
4343
final String? shell;

mono_repo/lib/src/commands/github/step.g.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

mono_repo/lib/src/github_config.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ class GitHubActionConfig implements GitHubActionOverrides {
176176
final String? uses;
177177

178178
@override
179-
final Map<String, String>? withContent;
179+
final Map<String, dynamic>? withContent;
180180

181181
@override
182182
final String? ifContent;

mono_repo/lib/src/task_type.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import 'package_flavor.dart';
1212

1313
abstract class TaskType implements Comparable<TaskType> {
1414
static const command = _CommandTask();
15+
1516
const factory TaskType.githubAction(GitHubActionConfig config) =
1617
_GitHubActionTaskType;
1718

@@ -168,14 +169,14 @@ class _TestWithCoverageTask extends TaskType {
168169
'github-token': r'${{ secrets.GITHUB_TOKEN }}',
169170
'path-to-lcov': '$packageDirectory/coverage/lcov.info',
170171
'flag-name': 'coverage_$countString',
171-
'parallel': 'true',
172+
'parallel': true,
172173
},
173174
),
174175
if (config.coverageProcessors.contains(CoverageProcessor.codecov))
175176
ActionInfo.codecov.usage(
176177
withContent: {
177178
'files': '$packageDirectory/coverage/lcov.info',
178-
'fail_ci_if_error': 'true',
179+
'fail_ci_if_error': true,
179180
'name': 'coverage_$countString',
180181
},
181182
),

0 commit comments

Comments
 (0)