Skip to content

Commit 8d4a865

Browse files
authored
Lighthouse update (#1536)
* updated scores * added link
1 parent dd23f92 commit 8d4a865

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

Diff for: packages/modelviewer.dev/assets/lighthouse2.png

128 KB
Loading

Diff for: packages/modelviewer.dev/examples/lighthouse2.html

+6-6
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@
126126
<div align="center" style="height:100%;">
127127
<!-- First Example -->
128128

129-
<h2>Setting up <code>&lt;model-viewer&gt;</code> for good Lighthouse scores</h2>
129+
<h2>Setting up <code>&lt;model-viewer&gt;</code> for decent Lighthouse scores</h2>
130130

131131
<model-viewer
132132
id="first"
@@ -153,8 +153,8 @@ <h2>Setting up <code>&lt;model-viewer&gt;</code> for good Lighthouse scores</h2>
153153
loads <code>model-viewer.min.js</code> immediately, which results in poorer
154154
lighthouse performance scores, as this bundle of JavaScript takes time to
155155
parse. We still make a strong effort to keep this bundle size down as much
156-
as possible to ensure this simple type of loading still gets decent
157-
performance.</p>
156+
as possible to ensure this simpler type of loading still gets decent
157+
performance, as this method does not require custom posters and such.</p>
158158

159159
<p>It is still important to delay the loading of the 3D model, as including
160160
its load time in the lighthouse scores will tend to destroy them. As such
@@ -163,10 +163,10 @@ <h2>Setting up <code>&lt;model-viewer&gt;</code> for good Lighthouse scores</h2>
163163
cause loading to proceed. The second <code>&lt;model-viewer&gt;</code> does
164164
not require this as it lazy-loads by default since it is below the fold.</p>
165165

166-
<img src="../assets/lighthouse.png" style="object-fit: contain; width:100%; max-width:700px;" alt="Lighthouse mobile scores">
166+
<img src="../assets/lighthouse2.png" style="object-fit: contain; width:100%; max-width:700px;" alt="Lighthouse mobile scores">
167167

168-
<p>Note the performance is worse than before, at only 97 for desktop and 92
169-
for mobile (shown above).</p>
168+
<p>Note the performance is worse than before, at only 93
169+
for mobile (shown above), though still 100 on desktop.</p>
170170

171171
<!-- Second Example -->
172172
<model-viewer

Diff for: packages/modelviewer.dev/index.html

+2
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ <h3 class="grouping-title border-bottom">Examples</h3>
8585

8686
<li><a href="examples/scene-graph.html"><h4>Scene Graph</h4></a></li>
8787

88+
<li><a href="examples/lighthouse.html"><h4>Performance</h4></a></li>
89+
8890
<li><a href="examples/tester.html"><h4>Interactive Example</h4></a></li>
8991

9092
<li><a href="editor"><h4>Model Editor</h4></a></li>

0 commit comments

Comments
 (0)