Skip to content

Commit 7fdf88c

Browse files
authored
Playwright CI (#4268)
* tests run * fixed most tests * fixed more tests * update CI * update effects testing * increase timeouts * disable firefox * simpler logs * longer timeouts * skip flaky tests * more flakes * more flakes * raf * ease up test * remove karma from model-viewer * space-opera jasmine->mocha * fixed tests * cleanup * update lock * extend timeout * up space-opera timeouts * webkit fail * debug CI * try disabling renderer suite * cleanup * add devices to CI * fixed more tests * deflake * remove old work-arounds * narrow webkit failure * cleanup * revert accidental replace
1 parent 3345a0a commit 7fdf88c

File tree

97 files changed

+8248
-16539
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

97 files changed

+8248
-16539
lines changed

.eslintignore

-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ packages/*/dist
44
packages/**/*.d.ts
55
packages/*/src/*-css.ts
66

7-
packages/*/karma.*.js
8-
97
packages/model-viewer/**/*
108
packages/model-viewer-effects/**/*
119
packages/modelviewer.dev/**/*

.github/workflows/unit-tests-third-party.yml

-31
This file was deleted.

.github/workflows/unit-tests.yml

+4-22
Original file line numberDiff line numberDiff line change
@@ -5,26 +5,10 @@ on: [push]
55
jobs:
66
full_test_run:
77

8-
env:
9-
USE_BROWSER_STACK: true
10-
118
runs-on: ubuntu-latest
129
timeout-minutes: 60
1310

1411
steps:
15-
- name: 'BrowserStack Env Setup' # Invokes the setup-env action
16-
uses: browserstack/github-actions/setup-env@master
17-
with:
18-
username: ${{ secrets.BROWSER_STACK_USERNAME }}
19-
access-key: ${{ secrets.BROWSER_STACK_ACCESS_KEY }}
20-
21-
- name: 'BrowserStack Local Tunnel Setup' # Invokes the setup-local action
22-
uses: browserstack/github-actions/setup-local@master
23-
with:
24-
local-testing: start
25-
local-identifier: test
26-
local-logging-level: setup-logs
27-
2812
- uses: actions/checkout@v3
2913
- uses: actions/setup-node@v3
3014
with:
@@ -33,6 +17,9 @@ jobs:
3317
- name: NPM install
3418
run: npm ci
3519

20+
- name: Install playwright browsers
21+
run: npx playwright install --with-deps
22+
3623
# - name: Lint TypeScript sources
3724
# run: npm run lint
3825

@@ -43,9 +30,4 @@ jobs:
4330
run: npm run build
4431

4532
- name: Unit tests
46-
run: npm run test:ci
47-
48-
- name: 'BrowserStackLocal Stop' # Terminating the BrowserStackLocal tunnel connection
49-
uses: browserstack/github-actions/setup-local@master
50-
with:
51-
local-testing: stop
33+
run: npm run test:ci

package-lock.json

+60-60
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)