Skip to content

Commit cafcb24

Browse files
kluevercopybara-github
authored andcommitted
Migrate from deprecated boxed primitive constructors to their replacements. E.g., new Integer(...) becomes Integer.valueOf(...).
The boxed primitive constructors are deprecated **for removal**. That means these APIs _will be deleted_ in a future JDK release and this library _will stop compiling_! NOTE: if piper is _not_ the source of truth for this 3p library, please work with upstream maintainers to land this change (it is your responsibility to do so --- see "Review & accept maintenance changes" @ go/thirdparty/responsibilities#owner). More info: go/boxed-primitive-constructors-lsc b/321209431 Tested: TAP --sample ran all affected tests and none failed http://test/OCL:608804363:BASE:608763264:1708480783015:e2655798 PiperOrigin-RevId: 608820838
1 parent c20e781 commit cafcb24

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

protobuf/tests/CompatibilityTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -650,18 +650,18 @@ public void testSetAndGetFieldWithFieldDescriptor() throws Exception {
650650
}
651651

652652
TypicalData.Builder dataBuilder = TypicalData.newBuilder();
653-
dataBuilder.setField(fields[1], new Integer(42));
653+
dataBuilder.setField(fields[1], Integer.valueOf(42));
654654
dataBuilder.setField(fields[2], ByteString.copyFromUtf8("foo"));
655655
dataBuilder.setField(fields[3], TypicalData.EnumType.VALUE9.getValueDescriptor());
656656
dataBuilder.setField(fields[11], TypicalDataMessage.newBuilder().build());
657657
dataBuilder.setField(fields[12], Boolean.TRUE);
658-
dataBuilder.setField(fields[13], new Float(43.8));
659-
dataBuilder.setField(fields[14], new Double(44.5));
658+
dataBuilder.setField(fields[13], Float.valueOf((float) 43.8));
659+
dataBuilder.setField(fields[14], Double.valueOf(44.5));
660660
dataBuilder.setField(fields[15], "bar");
661-
dataBuilder.setField(fields[16], new Integer(24));
662-
dataBuilder.setField(fields[17], new Long(4422));
663-
dataBuilder.setField(fields[18], new Long(2244));
664-
dataBuilder.addRepeatedField(fields[4], new Integer(72));
661+
dataBuilder.setField(fields[16], Integer.valueOf(24));
662+
dataBuilder.setField(fields[17], Long.valueOf(4422));
663+
dataBuilder.setField(fields[18], Long.valueOf(2244));
664+
dataBuilder.addRepeatedField(fields[4], Integer.valueOf(72));
665665
dataBuilder.addRepeatedField(fields[8], "aaa");
666666
dataBuilder.addRepeatedField(fields[8], "bbb");
667667
dataBuilder.setRepeatedField(fields[8], 1, "ccc");
@@ -679,8 +679,8 @@ private void checkGetters(TypicalDataOrBuilder data, FieldDescriptor[] fields) {
679679
assertEquals("foo", new String(data.getMyBytes().toByteArray()));
680680
assertEquals(TypicalData.EnumType.VALUE9, data.getMyEnumType());
681681
assertTrue(data.getMyBool());
682-
assertEquals(new Float(43.8), data.getMyFloat());
683-
assertEquals(new Double(44.5), data.getMyDouble());
682+
assertEquals(Float.valueOf((float) 43.8), data.getMyFloat());
683+
assertEquals(Double.valueOf(44.5), data.getMyDouble());
684684
assertEquals("bar", data.getMyString());
685685
assertEquals(24, data.getMyUint());
686686
assertEquals(4422, data.getMyLong());

0 commit comments

Comments
 (0)