@@ -1369,20 +1369,17 @@ func (vfs *VirtualFilesystem) GenerateProcMounts(ctx context.Context, taskRootDi
1369
1369
mount : mnt ,
1370
1370
dentry : mnt .root ,
1371
1371
}
1372
- if mp := vfs .getMountPromise (mntRootVD ); mp != nil && ! mp .resolved .Load () {
1373
- // Skip unresolved mount promises for consistency with
1374
- // GenerateProcMountInfo.
1375
- continue
1376
- }
1377
1372
path , err := vfs .PathnameReachable (ctx , taskRootDir , mntRootVD )
1378
1373
if err != nil {
1379
- // For some reason we didn't get a path.
1374
+ // For some reason we didn't get a path. Log a warning
1375
+ // and run with empty path.
1380
1376
ctx .Warningf ("VFS.GenerateProcMounts: error getting pathname for mount root: %v" , err )
1381
- continue
1377
+ path = ""
1382
1378
}
1383
1379
if path == "" {
1384
- // The path is not reachable from root.
1385
- continue
1380
+ // Either an error occurred, or path is not reachable
1381
+ // from root.
1382
+ break
1386
1383
}
1387
1384
1388
1385
mntOpts := mnt .Options ()
@@ -1443,14 +1440,10 @@ func (vfs *VirtualFilesystem) GenerateProcMountInfo(ctx context.Context, taskRoo
1443
1440
mount : mnt ,
1444
1441
dentry : mnt .root ,
1445
1442
}
1446
- if mp := vfs .getMountPromise (mntRootVD ); mp != nil && ! mp .resolved .Load () {
1447
- // Skip unresolved mount promises to prevent mounters from
1448
- // deadlocking by reading /proc/*/mountinfo.
1449
- continue
1450
- }
1451
1443
pathFromRoot , err := vfs .PathnameReachable (ctx , taskRootDir , mntRootVD )
1452
1444
if err != nil {
1453
- // For some reason we didn't get a path.
1445
+ // For some reason we didn't get a path. Log a warning
1446
+ // and run with empty path.
1454
1447
ctx .Warningf ("VFS.GenerateProcMountInfo: error getting pathname for mount root: %v" , err )
1455
1448
continue
1456
1449
}
0 commit comments