Skip to content

Commit bdbd27e

Browse files
authored
Merge branch 'google:master' into scroll-by-wheel-speedup
2 parents cd2dfbd + e33d0f0 commit bdbd27e

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

.github/workflows/build.yaml

+2-3
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,9 @@ jobs:
2727
- scrollable_positioned_list
2828
- self_storing_input
2929
- visibility_detector
30-
# Test against the Flutter stable and master SDKs.
30+
# Test against the Flutter stable SDK.
3131
version:
3232
- stable
33-
- master
3433
# For now, don't test visibility_detector against Flutter stable (3.0).
3534
# TODO: remove this after Flutter 3.2 ships.
3635
exclude:
@@ -58,7 +57,7 @@ jobs:
5857
- name: flutter format
5958
run: flutter format --dry-run --set-exit-if-changed .
6059
# Only test formatting on one version of Flutter.
61-
if: ${{ matrix.version == 'master' }}
60+
if: ${{ matrix.version == 'stable' }}
6261

6362
# A job configuration to do some light validation of the CI configuration.
6463
validate:

analysis_options.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ linter:
3131
- empty_statements
3232
- hash_and_equals
3333
- implementation_imports
34-
- invariant_booleans
3534
- iterable_contains_unrelated_type
3635
- library_names
3736
- library_prefixes

packages/scrollable_positioned_list/lib/src/positioned_list.dart

+1
Original file line numberDiff line numberDiff line change
@@ -345,6 +345,7 @@ class _PositionedListState extends State<PositionedList> {
345345
} else {
346346
final itemOffset =
347347
box.localToGlobal(Offset.zero, ancestor: viewport).dx;
348+
if (!itemOffset.isFinite) continue;
348349
positions.add(ItemPosition(
349350
index: key.value,
350351
itemLeadingEdge: (widget.reverse

0 commit comments

Comments
 (0)