Skip to content

[TS] --gen-all forgets to generate tables from non-leaf files #6739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephanemagnenat opened this issue Jul 19, 2021 · 7 comments
Closed

Comments

@stephanemagnenat
Copy link

Using Flatc version 2.0.0 (on Ubuntu 20.04), using the following files as a minimal test case:

all.fbs

include "game.fbs";

game.fbs

include "math.fbs";

table Game {
	point: Vector2;
}

math.fbs

struct Vector2 {
	x: float;
	y: float;
}

and generating using: flatc -o src --ts --gen-all ./all.fbs,

the resulting file src/all.ts exports table Vector2 but not Game:

export { Vector2 } from './vector2';

I assume this is a bug.

Probably unrelated, but if I generate to an absolute directory such as /tmp/fb: flatc -o /tmp/fb --ts --gen-all ./all.fbs, all.ts is not generated at all!

@aardappel
Copy link
Collaborator

@bjornharrtell any idea?

@bjornharrtell
Copy link
Collaborator

Agreed seems like bugs / untested cases. Will try to look into it when back from vacation. 🙂

@github-actions
Copy link
Contributor

This issue is stale because it has been open 6 months with no activity. Please comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jan 18, 2022
@stephanemagnenat
Copy link
Author

Any update on that issue?

@bjornharrtell
Copy link
Collaborator

Sorry nope. I have no current plans to work on it myself, unfortunately.

@github-actions github-actions bot removed the stale label Jan 19, 2022
@dbaileychess
Copy link
Collaborator

I think this is fixed now.

@stephanemagnenat
Copy link
Author

stephanemagnenat commented Nov 23, 2022

This is not fixed, you'll find a minimal test case here (tested with flatc 22.11.22):
https://github.com/stephanemagnenat/flatbuffers-6739

You'll noticed that src/all_generated.ts misses the Game table.

Plus there is now bug #7661 in addition.

@dbaileychess please re-open this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants