Skip to content

Commit db62c8c

Browse files
klueverError Prone Team
authored andcommitted
Automated rollback of commit e1b16e2.
*** Reason for rollback *** Causes errors when building `[ThreadSafe] @ThreadSafeTypeParameter is only supported on threadsafe classes` *** Original change description *** `@ImmutableTypeParameter` is really a subset of `@ThreadSafeTypeParameter`, much as `@Immutable` is a subset of `@ThreadSafe`. *** PiperOrigin-RevId: 798434994
1 parent 5ac2a3f commit db62c8c

File tree

2 files changed

+1
-22
lines changed

2 files changed

+1
-22
lines changed

core/src/main/java/com/google/errorprone/bugpatterns/threadsafety/ThreadSafety.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
import com.google.errorprone.VisitorState;
3333
import com.google.errorprone.annotations.CanIgnoreReturnValue;
3434
import com.google.errorprone.annotations.Immutable;
35-
import com.google.errorprone.annotations.ImmutableTypeParameter;
3635
import com.google.errorprone.annotations.ThreadSafe;
3736
import com.google.errorprone.annotations.ThreadSafeTypeParameter;
3837
import com.google.errorprone.bugpatterns.CanBeStaticAnalyzer;
@@ -95,10 +94,7 @@ public static ThreadSafety.Builder threadSafeBuilder(
9594
.knownTypes(wellKnownThreadSafety)
9695
.markerAnnotations(ImmutableSet.of(ThreadSafe.class.getName()))
9796
.acceptedAnnotations(ImmutableSet.of(Immutable.class.getName()))
98-
.typeParameterAnnotation(
99-
ImmutableSet.of(
100-
ThreadSafeTypeParameter.class.getName(),
101-
ImmutableTypeParameter.class.getName()));
97+
.typeParameterAnnotation(ImmutableSet.of(ThreadSafeTypeParameter.class.getName()));
10298
return builder;
10399
}
104100

core/src/test/java/com/google/errorprone/bugpatterns/threadsafety/ThreadSafeCheckerTest.java

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1353,23 +1353,6 @@ class Test<@ThreadSafeTypeParameter T> {
13531353
.doTest();
13541354
}
13551355

1356-
@Test
1357-
public void immutableTypeParam_alsoThreadSafe() {
1358-
compilationHelper
1359-
.addSourceLines(
1360-
"Test.java",
1361-
"""
1362-
import com.google.errorprone.annotations.ThreadSafe;
1363-
import com.google.errorprone.annotations.ImmutableTypeParameter;
1364-
1365-
@ThreadSafe
1366-
class Test<@ImmutableTypeParameter T> {
1367-
final T t = null;
1368-
}
1369-
""")
1370-
.doTest();
1371-
}
1372-
13731356
@Test
13741357
public void threadSafeTypeParameterInstantiation() {
13751358
compilationHelper

0 commit comments

Comments
 (0)