Skip to content

Commit 7d8fd68

Browse files
klueverError Prone Team
authored andcommitted
Add MVCE for o == Boolean.TRUE.
PiperOrigin-RevId: 778051376
1 parent 1d860db commit 7d8fd68

File tree

1 file changed

+34
-0
lines changed

1 file changed

+34
-0
lines changed

core/src/test/java/com/google/errorprone/bugpatterns/BooleanLiteralTest.java

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,4 +91,38 @@ public void moduleInfo() {
9191
.expectUnchanged()
9292
.doTest();
9393
}
94+
95+
@Test
96+
public void objectDoubleEqualsBooleanLiteral() {
97+
refactoringHelper
98+
.allowBreakingChanges()
99+
.addInputLines(
100+
"Test.java",
101+
"""
102+
class Test {
103+
boolean doubleEqualsBooleanTrue(Object o) {
104+
return o == Boolean.TRUE;
105+
}
106+
107+
boolean doubleEqualsBooleanFalse(Object o) {
108+
return o == Boolean.FALSE;
109+
}
110+
}
111+
""")
112+
// TODO: b/428921980 - this shouldn't get re-written because it doesn't compile!
113+
.addOutputLines(
114+
"Test.java",
115+
"""
116+
class Test {
117+
boolean doubleEqualsBooleanTrue(Object o) {
118+
return o == true;
119+
}
120+
121+
boolean doubleEqualsBooleanFalse(Object o) {
122+
return o == false;
123+
}
124+
}
125+
""")
126+
.doTest();
127+
}
94128
}

0 commit comments

Comments
 (0)