Revert to nogo instead of golangci-lint (#197)

* Revert to nogo instead of golangci-lint

Integration is simpler, and it now works with bzlmod.

* Fix warnings flagged by nogo

* Fix warnings flagged by nogo

Author: ralimi

.github/workflows/lint.yml

@@ -1,5 +1,4 @@
 {
-    "go.lintTool": "golangci-lint",
     "go.toolsEnvVars": {
         "GOOS": "js",
         "GOARCH": "wasm"

.golangci.yaml

@@ -2,6 +2,7 @@ load("@gazelle//:def.bzl", "gazelle")
 load("@npm//:defs.bzl", "npm_link_all_packages")
 load("@rules_pkg//:pkg.bzl", "pkg_zip")
 load("@rules_pkg//pkg:mappings.bzl", "pkg_filegroup", "pkg_files")
+load("@rules_go//go:def.bzl", "TOOLS_NOGO", "nogo")
 
 # Force Gazelle to choose the correct target when there are multiple go_library
 # targets in a single package.
@@ -21,6 +22,16 @@ gazelle(
     name = "gazelle",
     command = "fix",
 )
+nogo(
+    name = "chrome_ssh_agent_nogo",
+    config = ":nogo-config.json",
+    visibility = ["//visibility:public"],
+    deps = TOOLS_NOGO + [
+        # Prohibit build tags (e.g., //go:build ... ) within tests, as these may
+        # cause tests to silently be skipped unless we are extremely careful.
+        "//nogo/testbuildtags",
+    ],
+)
 
 exports_files([
     "go.mod",

.vscode/settings.json

@@ -19,6 +19,12 @@ go_sdk.download(
     # Use semver-coerced to handle versions where patches are left off (e.g., 1.19).
     version = "1.21.5",  # renovate: datasource=golang-version depName=golang versioning=semver-coerced
 )
+go_sdk.nogo(
+    nogo = "//:chrome_ssh_agent_nogo",
+    includes = [
+        "//:__subpackages__",
+    ],
+)
 use_repo(go_sdk, "go_sdk")
 
 # Pull in Go dependencies

BUILD.bazel

@@ -63,14 +63,14 @@ func UnzipTemp(path string) (string, CleanupFunc, error) {
 			}
 
 			if f.Mode().IsDir() {
-				if err := os.MkdirAll(filePath, os.ModePerm); err != nil {
-					return fmt.Errorf("Failed to create destination directory %s: %w", filepath.Dir(filePath), err)
+				if merr := os.MkdirAll(filePath, os.ModePerm); merr != nil {
+					return fmt.Errorf("Failed to create destination directory %s: %w", filepath.Dir(filePath), merr)
 				}
 				return nil
 			}
 
-			if err := os.MkdirAll(filepath.Dir(filePath), os.ModePerm); err != nil {
-				return fmt.Errorf("Failed to create destination directory %s: %w", filepath.Dir(filePath), err)
+			if merr := os.MkdirAll(filepath.Dir(filePath), os.ModePerm); merr != nil {
+				return fmt.Errorf("Failed to create destination directory %s: %w", filepath.Dir(filePath), merr)
 			}
 
 			dstFile, err := os.OpenFile(filePath, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, f.Mode())

MODULE.bazel

@@ -0,0 +1,42 @@
+{
+  "composites": {
+    "exclude_files": {
+      "external/.*": "Ignore for third-party code"
+    }
+  },
+  "copylocks": {
+    "exclude_files": {
+      "external/.*": "Ignore for third-party code"
+    }
+  },
+  "nilness": {
+    "exclude_files": {
+      "external/.*": "Ignore for third-party code"
+    }
+  },
+  "shadow": {
+    "exclude_files": {
+      "external/.*": "Ignore for third-party code"
+    }
+  },
+  "stdmethods": {
+    "exclude_files": {
+      "external/.*": "Ignore for third-party code"
+    }
+  },
+  "structtag": {
+    "exclude_files": {
+      "external/.*": "Ignore for third-party code"
+    }
+  },
+  "unreachable": {
+    "exclude_files": {
+      "external/.*": "Ignore for third-party code"
+    }
+  },
+  "unsafeptr": {
+    "exclude_files": {
+      "external/org_golang_x_sys/unix/.*": "Ignore for code not used on Javascript platforms"
+    }
+  } 
+}

go.work

@@ -20,10 +20,6 @@
 // being executed.
 //
 
-// TODO: Find a way to re-enable this static analyzer. See
-//
-//	https://github.com/google/chrome-ssh-agent/issues/163
-//
 //nolint:godox
 package testbuildtags
 

go/testutil/unzip.go

@@ -133,8 +133,8 @@ func TestWebApp(t *testing.T) {
 				t.Fatalf("failed to start Selenium service: %v", err)
 			}
 			defer func() {
-				if err := service.Stop(); err != nil {
-					t.Errorf("failed to stop Selenium service: %v", err)
+				if serr := service.Stop(); serr != nil {
+					t.Errorf("failed to stop Selenium service: %v", serr)
 				}
 			}()
 
@@ -170,8 +170,8 @@ func TestWebApp(t *testing.T) {
 				t.Fatalf("Failed to start webdriver: %v", err)
 			}
 			defer func() {
-				if err := wd.Quit(); err != nil {
-					t.Errorf("failed to quit webdriver: %v", err)
+				if qerr := wd.Quit(); qerr != nil {
+					t.Errorf("failed to quit webdriver: %v", qerr)
 				}
 			}()
 			defer dumpSeleniumLogs(t, wd)