Skip to content

Commit ae814a5

Browse files
committed
Merge pull request #1233 from ausil/master
ClockSpeed not defined in /proc/cpuinfo for 32 bit arm, so return 0.
2 parents 0ac3342 + fcf5431 commit ae814a5

File tree

1 file changed

+13
-8
lines changed

1 file changed

+13
-8
lines changed

utils/machine/machine.go

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ const maxFreqFile = "/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq"
4949

5050
// GetClockSpeed returns the CPU clock speed, given a []byte formatted as the /proc/cpuinfo file.
5151
func GetClockSpeed(procInfo []byte) (uint64, error) {
52-
// s390/s390x and aarch64 changes
53-
if true == isSystemZ() || true == isAArch64() {
52+
// s390/s390x, aarch64 and arm32 changes
53+
if isSystemZ() || isAArch64() || isArm32() {
5454
return 0, nil
5555
}
5656

@@ -280,13 +280,20 @@ func getMachineArch() (string, error) {
280280
return arch, nil
281281
}
282282

283+
// arm32 chanes
284+
func isArm32() bool {
285+
arch, err := getMachineArch()
286+
if err == nil {
287+
return strings.Contains(arch, "arm")
288+
}
289+
return false
290+
}
291+
283292
// aarch64 changes
284293
func isAArch64() bool {
285294
arch, err := getMachineArch()
286295
if err == nil {
287-
if true == strings.Contains(arch, "aarch64") {
288-
return true
289-
}
296+
return strings.Contains(arch, "aarch64")
290297
}
291298
return false
292299
}
@@ -295,9 +302,7 @@ func isAArch64() bool {
295302
func isSystemZ() bool {
296303
arch, err := getMachineArch()
297304
if err == nil {
298-
if true == strings.Contains(arch, "390") {
299-
return true
300-
}
305+
return strings.Contains(arch, "390")
301306
}
302307
return false
303308
}

0 commit comments

Comments
 (0)