From 072eec08c3ab48cb0569d42f36901ef6f3400981 Mon Sep 17 00:00:00 2001 From: Dirk Pranke Date: Tue, 21 Jan 2025 13:09:44 -0800 Subject: [PATCH] Use `exec_script_allowlist` in GN now that it is available. This CL renames the gn dotfile variable `exec_script_whitelist` to `exec_script_allowlist`, in order to be more inclusive. Bug: chromium:40713186 Change-Id: Iaf5ef131a64f3189e675acfd090c7043c3138df8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6188240 Reviewed-by: Geoff Lang Commit-Queue: Dirk Pranke Commit-Queue: Geoff Lang --- .gn | 4 ++-- dotfile_settings.gni | 6 +++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.gn b/.gn index 87eb8ecf0ff..a16b15b324d 100644 --- a/.gn +++ b/.gn @@ -26,8 +26,8 @@ script_executable = "python3" # These are the list of GN files that run exec_script. This allowlist exists # to force additional review for new uses of exec_script, which is strongly # discouraged except for gypi_to_gn calls. -exec_script_whitelist = angle_dotfile_settings.exec_script_whitelist + - build_dotfile_settings.exec_script_whitelist + +exec_script_allowlist = angle_dotfile_settings.exec_script_allowlist + + build_dotfile_settings.exec_script_allowlist + [ "//build/config/sysroot.gni", "//build/config/win/BUILD.gn", diff --git a/dotfile_settings.gni b/dotfile_settings.gni index d42beef6fe8..91b2b34d6c3 100644 --- a/dotfile_settings.gni +++ b/dotfile_settings.gni @@ -6,5 +6,9 @@ # to make it easier to roll new versions of ANGLE in. angle_dotfile_settings = { - exec_script_whitelist = [ get_path_info("BUILD.gn", "abspath") ] + exec_script_allowlist = [ get_path_info("BUILD.gn", "abspath") ] + + # TODO(crbug.com/389986807) - move other clients to `exec_script_allowlist` + # so that we don't need to keep supporting `exec_script_whitelist`. + exec_script_whitelist = exec_script_allowlist }