Skip to content

Commit 2576453

Browse files
fix: UTCs of AgentCardBuilder
1 parent ad470da commit 2576453

File tree

1 file changed

+5
-13
lines changed

1 file changed

+5
-13
lines changed

tests/unittests/a2a/utils/test_agent_card_builder.py

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ def test_init_with_valid_agent(self):
107107
assert builder._agent == mock_agent
108108
assert builder._rpc_url == "http://localhost:80/a2a"
109109
assert isinstance(builder._capabilities, AgentCapabilities)
110-
assert builder._doc_url is None
111110
assert builder._provider is None
112111
assert builder._security_schemes is None
113112
assert builder._agent_version == "0.0.1"
@@ -126,7 +125,6 @@ def test_init_with_custom_parameters(self):
126125
agent=mock_agent,
127126
rpc_url="https://example.com/a2a",
128127
capabilities=mock_capabilities,
129-
doc_url="https://docs.example.com",
130128
provider=mock_provider,
131129
agent_version="1.2.3",
132130
security_schemes=mock_security_schemes,
@@ -136,7 +134,6 @@ def test_init_with_custom_parameters(self):
136134
assert builder._agent == mock_agent
137135
assert builder._rpc_url == "https://example.com/a2a"
138136
assert builder._capabilities == mock_capabilities
139-
assert builder._doc_url == "https://docs.example.com"
140137
assert builder._provider == mock_provider
141138
assert builder._security_schemes == mock_security_schemes
142139
assert builder._agent_version == "1.2.3"
@@ -181,15 +178,14 @@ async def test_build_success(
181178
assert isinstance(result, AgentCard)
182179
assert result.name == "test_agent"
183180
assert result.description == "Test agent description"
184-
assert result.documentationUrl is None
185181
assert result.url == "http://localhost:80/a2a"
186182
assert result.version == "0.0.1"
187183
assert result.skills == [mock_primary_skill, mock_sub_skill]
188-
assert result.defaultInputModes == ["text/plain"]
189-
assert result.defaultOutputModes == ["text/plain"]
190-
assert result.supportsAuthenticatedExtendedCard is False
184+
assert result.default_input_modes == ["text/plain"]
185+
assert result.default_output_modes == ["text/plain"]
186+
assert result.supports_authenticated_extended_card is False
191187
assert result.provider is None
192-
assert result.securitySchemes is None
188+
assert result.security_schemes is None
193189

194190
@patch("google.adk.a2a.utils.agent_card_builder._build_primary_skills")
195191
@patch("google.adk.a2a.utils.agent_card_builder._build_sub_agent_skills")
@@ -213,7 +209,6 @@ async def test_build_with_custom_parameters(
213209
builder = AgentCardBuilder(
214210
agent=mock_agent,
215211
rpc_url="https://example.com/a2a/",
216-
doc_url="https://docs.example.com",
217212
provider=mock_provider,
218213
agent_version="2.0.0",
219214
security_schemes=mock_security_schemes,
@@ -225,15 +220,12 @@ async def test_build_with_custom_parameters(
225220
# Assert
226221
assert result.name == "test_agent"
227222
assert result.description == "An ADK Agent" # Default description
228-
# The source code uses doc_url parameter but AgentCard expects documentationUrl
229-
# Since the source code doesn't map doc_url to documentationUrl, it will be None
230-
assert result.documentationUrl is None
231223
assert (
232224
result.url == "https://example.com/a2a"
233225
) # Should strip trailing slash
234226
assert result.version == "2.0.0"
235227
assert result.provider == mock_provider
236-
assert result.securitySchemes == mock_security_schemes
228+
assert result.security_schemes == mock_security_schemes
237229

238230
@patch("google.adk.a2a.utils.agent_card_builder._build_primary_skills")
239231
@patch("google.adk.a2a.utils.agent_card_builder._build_sub_agent_skills")

0 commit comments

Comments
 (0)