Skip to content

Commit 0271ba2

Browse files
authored
Bump to Node 24 and remove deprecated fields (#576)
1 parent 012c06a commit 0271ba2

File tree

10 files changed

+111
-133
lines changed

10 files changed

+111
-133
lines changed

.github/actionlint.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
paths:
2+
'**/*.yml':
3+
ignore:
4+
# https://github.com/rhysd/actionlint/issues/559
5+
- 'invalid runner name "node24"'

.github/workflows/cleanup.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,9 @@ name: 'Cleanup'
22

33
on:
44
pull_request:
5-
branches:
6-
- 'main'
7-
- 'release/**'
85
paths:
96
- '.github/workflows/cleanup.yml'
107
push:
11-
branches:
12-
- 'main'
13-
- 'release/**'
148
paths:
159
- '.github/workflows/cleanup.yml'
1610
schedule:
@@ -35,7 +29,7 @@ jobs:
3529
steps:
3630
- uses: 'actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683' # ratchet:actions/checkout@v4
3731

38-
- uses: 'google-github-actions/auth@v2' # ratchet:exclude
32+
- uses: 'google-github-actions/auth@v3' # ratchet:exclude
3933
with:
4034
workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}'
4135
service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}'

.github/workflows/integration.yml

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ jobs:
5454

5555
- run: 'npm ci && npm run build'
5656

57-
- uses: 'google-github-actions/auth@v2' # ratchet:exclude
57+
- uses: 'google-github-actions/auth@v3' # ratchet:exclude
5858
with:
5959
workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}'
6060
service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}'
@@ -69,7 +69,6 @@ jobs:
6969
env_vars: |-
7070
FOO=bar
7171
ZIP=zap\,with|separators\,and&stuff
72-
env_vars_file: './tests/fixtures/env_vars.txt'
7372
secrets: |-
7473
MY_SECRET=${{ vars.SECRET_NAME }}:latest
7574
MY_SECOND_SECRET=${{ vars.SECRET_NAME }}:1
@@ -87,9 +86,7 @@ jobs:
8786
ENV: |-
8887
{
8988
"FOO": "bar",
90-
"ZIP": "zap,with|separators,and&stuff",
91-
"TEXT_FOO": "bar",
92-
"TEXT_ZIP": "zap,with|separators,and&stuff"
89+
"ZIP": "zap,with|separators,and&stuff"
9390
}
9491
SECRET_ENV: |-
9592
{
@@ -173,7 +170,7 @@ jobs:
173170

174171
- run: 'npm ci && npm run build'
175172

176-
- uses: 'google-github-actions/auth@v2' # ratchet:exclude
173+
- uses: 'google-github-actions/auth@v3' # ratchet:exclude
177174
with:
178175
workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}'
179176
service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}'
@@ -246,7 +243,7 @@ jobs:
246243

247244
- run: 'npm ci && npm run build'
248245

249-
- uses: 'google-github-actions/auth@v2' # ratchet:exclude
246+
- uses: 'google-github-actions/auth@v3' # ratchet:exclude
250247
with:
251248
workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}'
252249
service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}'
@@ -260,7 +257,6 @@ jobs:
260257
env_vars: |-
261258
FOO=bar
262259
ZIP=zap\,with|separators\,and&stuff
263-
env_vars_file: './tests/fixtures/env_vars.txt'
264260
secrets: |-
265261
MY_SECRET=${{ vars.SECRET_NAME }}:latest
266262
MY_SECOND_SECRET=${{ vars.SECRET_NAME }}:1
@@ -278,9 +274,7 @@ jobs:
278274
ENV: |-
279275
{
280276
"FOO": "bar",
281-
"ZIP": "zap,with|separators,and&stuff",
282-
"TEXT_FOO": "bar",
283-
"TEXT_ZIP": "zap,with|separators,and&stuff"
277+
"ZIP": "zap,with|separators,and&stuff"
284278
}
285279
SECRET_ENV: |-
286280
{

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ support](https://cloud.google.com/support).**
1616
the secrets being requested. See [Authorization](#authorization) for more
1717
information.
1818

19-
- This action runs using Node 20. If you are using self-hosted GitHub Actions
19+
- This action runs using Node 24. If you are using self-hosted GitHub Actions
2020
runners, you must use a [runner
2121
version](https://github.com/actions/virtual-environments) that supports this
2222
version or newer.
@@ -36,13 +36,13 @@ jobs:
3636
steps:
3737
- uses: 'actions/checkout@v4'
3838

39-
- uses: 'google-github-actions/auth@v2'
39+
- uses: 'google-github-actions/auth@v3'
4040
with:
4141
workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider'
4242
service_account: '[email protected]'
4343

4444
- id: 'deploy'
45-
uses: 'google-github-actions/deploy-cloudrun@v2'
45+
uses: 'google-github-actions/deploy-cloudrun@v3'
4646
with:
4747
service: 'hello-cloud-run'
4848
image: 'us-docker.pkg.dev/cloudrun/container/hello:latest'
@@ -358,12 +358,12 @@ jobs:
358358
359359
# ...
360360
361-
- uses: 'google-github-actions/auth@v2'
361+
- uses: 'google-github-actions/auth@v3'
362362
with:
363363
workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider'
364364
service_account: '[email protected]'
365365
366-
- uses: 'google-github-actions/deploy-cloudrun@v2'
366+
- uses: 'google-github-actions/deploy-cloudrun@v3'
367367
with:
368368
image: 'us-docker.pkg.dev/cloudrun/container/hello:latest'
369369
service: 'hello-cloud-run'
@@ -382,7 +382,7 @@ jobs:
382382
steps:
383383
# ...
384384
385-
- uses: 'google-github-actions/deploy-cloudrun@v2'
385+
- uses: 'google-github-actions/deploy-cloudrun@v3'
386386
with:
387387
image: 'us-docker.pkg.dev/cloudrun/container/hello:latest'
388388
service: 'hello-cloud-run'

action.yml

Lines changed: 47 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,11 @@ inputs:
7474
`\\n`) unless quoted. Any leading or trailing whitespace is trimmed unless
7575
values are quoted.
7676
77-
env_vars: |-
78-
FRUIT=apple
79-
SENTENCE=" this will retain leading and trailing spaces "
77+
```yaml
78+
env_vars: |-
79+
FRUIT=apple
80+
SENTENCE=" this will retain leading and trailing spaces "
81+
```
8082
8183
This value will only be set if the input is a non-empty value. If a
8284
non-empty value is given, the field values will be overwritten (not
@@ -86,27 +88,6 @@ inputs:
8688
`env_vars` will take precedence over the keys in `env_vars_file`.
8789
required: false
8890

89-
env_vars_file:
90-
description: |-
91-
Path to a file on disk, relative to the workspace, that defines
92-
environment variables. The file can be newline-separated KEY=VALUE pairs,
93-
JSON, or YAML format. If both `env_vars` and `env_vars_file` are
94-
specified, the keys in env_vars will take precedence over the keys in
95-
env_vars_file.
96-
97-
NAME=person
98-
99-
100-
When specified as KEY=VALUE pairs, the same escaping rules apply as
101-
described in `env_vars`. You do not have to escape YAML or JSON.
102-
103-
If both `env_vars` and `env_vars_file` are specified, the keys in
104-
`env_vars` will take precedence over the keys in `env_vars_file`.
105-
106-
**⚠️ DEPRECATION NOTICE:** This input is deprecated and will be removed in
107-
the next major version release.
108-
required: false
109-
11091
env_vars_update_strategy:
11192
description: |-
11293
Controls how the environment variables are set on the Cloud Run service.
@@ -128,13 +109,15 @@ inputs:
128109
volumes. Keys starting with a forward slash '/' are mount paths. All other
129110
keys correspond to environment variables:
130111
131-
with:
132-
secrets: |-
133-
# As an environment variable:
134-
KEY1=secret-key-1:latest
112+
```yaml
113+
with:
114+
secrets: |-
115+
# As an environment variable:
116+
KEY1=secret-key-1:latest
135117
136-
# As a volume mount:
137-
/secrets/api/key=secret-key-2:latest
118+
# As a volume mount:
119+
/secrets/api/key=secret-key-2:latest
120+
```
138121
139122
This value will only be set if the input is a non-empty value. If a
140123
non-empty value is given, the field values will be overwritten (not
@@ -159,9 +142,11 @@ inputs:
159142
unless quoted. Any leading or trailing whitespace is trimmed unless values
160143
are quoted.
161144
162-
labels: |-
163-
labela=my-label
164-
labelb=my-other-label
145+
```yaml
146+
labels: |-
147+
labela=my-label
148+
labelb=my-other-label
149+
```
165150
166151
This value will only be set if the input is a non-empty value. If a
167152
non-empty value is given, the field values will be overwritten (not
@@ -204,14 +189,18 @@ inputs:
204189
`gcloud run deploy`. For Cloud Run jobs, this command will be `gcloud jobs
205190
deploy`.
206191
207-
with:
208-
flags: '--add-cloudsql-instances=...'
192+
```yaml
193+
with:
194+
flags: '--add-cloudsql-instances=...'
195+
```
209196
210197
Flags that include other flags must quote the _entire_ outer flag value. For
211198
example, to pass `--args=-X=123`:
212199
213-
with:
214-
flags: '--add-cloudsql-instances=... "--args=-X=123"'
200+
```yaml
201+
with:
202+
flags: '--add-cloudsql-instances=... "--args=-X=123"'
203+
```
215204
216205
See the [complete list of
217206
flags](https://cloud.google.com/sdk/gcloud/reference/run/deploy#FLAGS) for
@@ -240,13 +229,17 @@ inputs:
240229
description: |-
241230
Comma-separated list of revision traffic assignments.
242231
243-
with:
244-
revision_traffic: 'my-revision=10' # percentage
232+
```yaml
233+
with:
234+
revision_traffic: 'my-revision=10' # percentage
235+
```
245236
246237
To update traffic to the latest revision, use the special tag "LATEST":
247238
248-
with:
249-
revision_traffic: 'LATEST=100'
239+
```yaml
240+
with:
241+
revision_traffic: 'LATEST=100'
242+
```
250243
251244
This is mutually-exclusive with `tag_traffic`. This option only applies
252245
to services.
@@ -256,8 +249,10 @@ inputs:
256249
description: |-
257250
Comma-separated list of tag traffic assignments.
258251
259-
with:
260-
tag_traffic: 'my-tag=10' # percentage
252+
```yaml
253+
with:
254+
tag_traffic: 'my-tag=10' # percentage
255+
```
261256
262257
This is mutually-exclusive with `revision_traffic`. This option only
263258
applies to services.
@@ -270,14 +265,18 @@ inputs:
270265
features that are not exposed via this GitHub Action. This flag only
271266
applies when `revision_traffic` or `tag_traffic` is set.
272267
273-
with:
274-
traffic_flags: '--set-tags=...'
268+
```yaml
269+
with:
270+
traffic_flags: '--set-tags=...'
271+
```
275272
276273
Flags that include other flags must quote the _entire_ outer flag value. For
277274
example, to pass `--args=-X=123`:
278275
279-
with:
280-
flags: '--set-tags=... "--args=-X=123"'
276+
```yaml
277+
with:
278+
flags: '--set-tags=... "--args=-X=123"'
279+
```
281280
282281
See the [complete list of
283282
flags](https://cloud.google.com/sdk/gcloud/reference/run/services/update#FLAGS)
@@ -321,5 +320,5 @@ branding:
321320
color: 'blue'
322321

323322
runs:
324-
using: 'node20'
323+
using: 'node24'
325324
main: 'dist/main/index.js'

0 commit comments

Comments
 (0)