Commit 17390e5
committed
[release-v0.46]extension/src/language: check token field existence before assertion
The error happens when the workspace/executeCommand returns results
without any token. vscode-go tried to assert the type of "Token"
field without checking for it's existence.
Command with token returned (gopls.vulncheck):
https://github.com/user-attachments/assets/931524ba-a40b-4a8c-b7af-a350a4c9a135
Command without token returned (gopls.upgrade_dependency):
https://github.com/user-attachments/assets/cb23c5bc-7d0b-4e60-aa4e-66ba1fed31d8
For #3698
Change-Id: I07183b7e0f30912a6b3f6c0ab53a40624ccd7880
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/654555
Reviewed-by: Robert Findley <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
kokoro-CI: kokoro <[email protected]>
Reviewed-by: Madeline Kalil <[email protected]>
(cherry picked from commit 7a2c835)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/6547751 parent 07561fd commit 17390e5
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
565 | 565 | | |
566 | 566 | | |
567 | 567 | | |
568 | | - | |
| 568 | + | |
569 | 569 | | |
570 | 570 | | |
571 | 571 | | |
| |||
0 commit comments