Skip to content

Commit 8127761

Browse files
committed
gopls/internal/settings: drop experimental hoverKind=Structured
We thought it was used by govim, but apparently not. Fixes golang/go#70233 Change-Id: Iacd85833dba91e870accf038e1c69a01e42fca1f Reviewed-on: https://go-review.googlesource.com/c/tools/+/635226 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Robert Findley <[email protected]>
1 parent 7bfb27f commit 8127761

File tree

6 files changed

+111
-123
lines changed

6 files changed

+111
-123
lines changed

gopls/doc/release/v0.18.0.md

+2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# Configuration Changes
22

3+
- The experimental `hoverKind=Structured` setting is no longer supported.
4+
35
# New features
46

57
## "Implementations" supports generics

gopls/doc/settings.md

+1-5
Original file line numberDiff line numberDiff line change
@@ -399,17 +399,13 @@ Default: `true`.
399399
### `hoverKind enum`
400400

401401
hoverKind controls the information that appears in the hover text.
402-
SingleLine and Structured are intended for use only by authors of editor plugins.
402+
SingleLine is intended for use only by authors of editor plugins.
403403

404404
Must be one of:
405405

406406
* `"FullDocumentation"`
407407
* `"NoDocumentation"`
408408
* `"SingleLine"`
409-
* `"Structured"` is an experimental setting that returns a structured hover format.
410-
This format separates the signature from the documentation, so that the client
411-
can do more manipulation of these fields.\
412-
This should only be used by clients that support this behavior.
413409
* `"SynopsisDocumentation"`
414410

415411
Default: `"FullDocumentation"`.

gopls/internal/doc/api.json

+1-5
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@
9595
{
9696
"Name": "hoverKind",
9797
"Type": "enum",
98-
"Doc": "hoverKind controls the information that appears in the hover text.\nSingleLine and Structured are intended for use only by authors of editor plugins.\n",
98+
"Doc": "hoverKind controls the information that appears in the hover text.\nSingleLine is intended for use only by authors of editor plugins.\n",
9999
"EnumKeys": {
100100
"ValueType": "",
101101
"Keys": null
@@ -113,10 +113,6 @@
113113
"Value": "\"SingleLine\"",
114114
"Doc": ""
115115
},
116-
{
117-
"Value": "\"Structured\"",
118-
"Doc": "`\"Structured\"` is an experimental setting that returns a structured hover format.\nThis format separates the signature from the documentation, so that the client\ncan do more manipulation of these fields.\n\nThis should only be used by clients that support this behavior.\n"
119-
},
120116
{
121117
"Value": "\"SynopsisDocumentation\"",
122118
"Doc": ""

0 commit comments

Comments
 (0)