Skip to content

x/tools/gopls: temporarily revert the removal of Structured hoverkind #71879

Closed
@bhcleek

Description

@bhcleek

gopls version

golang.org/x/tools/gopls v0.18.0

go env

GO111MODULE=''
GOARCH='arm64'
GOBIN='/Users/bhcleek/go/bin'
GOCACHE='/Users/bhcleek/Library/Caches/go-build'
GOENV='/Users/bhcleek/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/bhcleek/go/pkg/mod'
GONOPROXY='*.internal.digitalocean.com,github.com/digitalocean'
GONOSUMDB='*.internal.digitalocean.com,github.com/digitalocean'
GOOS='darwin'
GOPATH='/Users/bhcleek/go'
GOPRIVATE='*.internal.digitalocean.com,github.com/digitalocean'
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.23.0'
GODEBUG=''
GOTELEMETRY='local'
GOTELEMETRYDIR='/Users/bhcleek/Library/Application Support/go/telemetry'
GCCGO='gccgo'
GOARM64='v8.0'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/f9/d6g779t53gq_20w0zm2f_1zm0000gn/T/go-build530885244=/tmp/go-build -gno-record-gcc-switches -fno-common'

What did you do?

Updated to gopls v0.18.0.

What did you see happen?

gopls v0.18.0 removed structured hover results, breaking vim-go. Vim-go has a few features that depended on the structured result: :GoDoc, hover balloon documentation, and :GoDocBrowser all depended on that structure (and not all for the same reason).

fatih/vim-go#3701 was created this morning, but only documents one of the issues that this change caused.

Is it possible to revert? If not, where can I find a clear definition of the data and its structure that each of the hoverKind values will return, especially FullDocumentation?

What did you expect to see?

Documentation

Editor and settings

Vim w/ vim-go

Logs

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    ToolProposalIssues describing a requested change to a Go tool or command-line program.ToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions