Skip to content

Commit 457418b

Browse files
committed
cmd/go: fix long test builders
CL 343732 enabled -G=3 by default. The types2 typechecker uses slighly different error message format for language feature constraint. The old typechecker format: vendor/example.net/need117/need117.go:5:16: cannot convert s (type []byte) to type *[4]byte: conversion of slices to array pointers only supported as of -lang=go1.17 The new format: vendor/example.net/need117/need117.go:5:17: conversion of slices to array pointers only supported as of -lang=go1.17 caused the long test builders failed. This CL fixes the test by relaxing the regext pattern a bit, so it can match both the format. Change-Id: I1c4acaa9e34b6c08dccbbc3ce7a99d4cd79f748a Reviewed-on: https://go-review.googlesource.com/c/go/+/344212 Trust: Cuong Manh Le <[email protected]> Trust: Robert Griesemer <[email protected]> Run-TryBot: Cuong Manh Le <[email protected]> Run-TryBot: Robert Griesemer <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Robert Griesemer <[email protected]>
1 parent 86ee892 commit 457418b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/cmd/go/testdata/script/mod_vendor_goversion.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ go mod vendor
2626

2727
! grep 1.17 vendor/modules.txt
2828
! go build example.net/need117
29-
stderr '^vendor[/\\]example\.net[/\\]need117[/\\]need117.go:5:18: .*\n\tconversion of slices to array pointers only supported as of -lang=go1\.17'
29+
stderr '^vendor[/\\]example\.net[/\\]need117[/\\]need117.go:5:1[89]: .*conversion of slices to array pointers only supported as of -lang=go1\.17'
3030

3131
! grep 1.13 vendor/modules.txt
3232
go build example.net/bad114

0 commit comments

Comments
 (0)