Revert "cmd/go/internal/test: add 'tests' vet check to 'go test' suite"

This reverts commit f1d6050.

Reason for revert: Broke the longtest builders.

Change-Id: I5f3510c8ffc24fae5e71fac0a2dbda01ecfe5d5c
Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest
Reviewed-on: https://go-review.googlesource.com/c/go/+/571695
Reviewed-by: Alan Donovan <[email protected]>
Auto-Submit: Michael Knyszek <[email protected]>
Reviewed-by: Russ Cox <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>

Author: mknyszek

doc/next/3-tools.md

@@ -10,12 +10,3 @@ or copying the `go` binary.
 
 ### Cgo {#cgo}
 
-### Vet
-
-The new `tests` analyzer reports common mistakes in declarations of
-tests, fuzzers, benchmarks, and examples in test packages, such as
-malformed names, wrong signatures, or examples that document
-non-existent identifiers. Some of these mistakes may cause tests not
-to run.
-
-This analyzer is among the subset of analyzers that are run by `go test`.

src/cmd/go/alldocs.go

@@ -79,7 +79,7 @@ and its test source files to identify significant problems. If go vet
 finds any problems, go test reports those and does not run the test
 binary. Only a high-confidence subset of the default go vet checks are
 used. That subset is: atomic, bool, buildtags, directive, errorsas,
-ifaceassert, nilfunc, printf, stringintconv, and tests. You can see
+ifaceassert, nilfunc, printf, and stringintconv. You can see
 the documentation for these and other vet tests via "go doc cmd/vet".
 To disable the running of go vet, use the -vet=off flag. To run all
 checks, use the -vet=all flag.
@@ -667,7 +667,7 @@ var defaultVetFlags = []string{
 	"-slog",
 	"-stringintconv",
 	// "-structtags",
-	"-tests",
+	// "-tests",
 	// "-unreachable",
 	// "-unsafeptr",
 	// "-unusedresult",

src/cmd/go/internal/test/test.go

@@ -1,7 +1,6 @@
 # Tests that invalid examples are ignored.
 # Verifies golang.org/issue/35284
-# Disable vet, as 'tests' analyzer objects to surplus parameter.
-go test -vet=off x_test.go
+go test x_test.go
 
 -- x_test.go --
 package  x
@@ -11,4 +10,4 @@ import "fmt"
 func ExampleThisShouldNotHaveAParameter(thisShouldntExist int) {
 	fmt.Println("X")
 	// Output:
-}
+}