-
-
Notifications
You must be signed in to change notification settings - Fork 23.8k
Add cubic root function #112430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add cubic root function #112430
Conversation
|
Is there a proposal for this function? |
|
Considering we only use it exactly twice in the whole codebase I think is indicative of that we should gauge if the community actually needs this and the precision difference (the actual difference is almost completely negligible, probably within one or two epsilon, note also that unlike |
|
Mmm. I'd say exposing this function would be quite hasty, especially without any corresponding proposal. |
|
I did a search and there are no cases where |
|
Yyyeah, it's too niche. I would personally move this function to |
|
One method I'd say we should consider adding is |
I think this function is a useful addition. Previously, user may use:
pow(number, 1.0 / 3.0)- compared to it, according to C++ documentation (https://en.cppreference.com/w/cpp/numeric/math/cbrt) this function should work faster and more precise.