Run CI against both Godot stable/nightly versions; remove gcc memcheck

Author: Bromeon

.github/composite/godot-install/action.yml

@@ -37,13 +37,19 @@ runs:
 #      shell: bash
 
     - name: "Download Godot artifact"
+      env:
+        ARTIFACT_NAME: ${{ inputs.artifact-name }}
 #      if: steps.cache-godot.outputs.cache-hit != 'true'
       # If a specific Godot revision should be used, rather than latest, use this:
       # curl https://nightly.link/Bromeon/godot4-nightly/actions/runs/4910907653/${{ inputs.artifact-name }}.zip \
       run: |
-        curl https://nightly.link/Bromeon/godot4-nightly/workflows/compile-godot/master/${{ inputs.artifact-name }}.zip \
-          -Lo artifact.zip \
-          --retry 3
+        if [[ $ARTIFACT_NAME == *"stable"* ]]; then
+          url="https://nightly.link/Bromeon/godot4-nightly/workflows/compile-godot-stable/master/$ARTIFACT_NAME.zip"
+        else
+          url="https://nightly.link/Bromeon/godot4-nightly/workflows/compile-godot-nightly/master/$ARTIFACT_NAME.zip"
+        fi
+        
+        curl "$url" -Lo artifact.zip --retry 3
         unzip artifact.zip -d $RUNNER_DIR/godot_bin
       shell: bash
 

.github/workflows/full-ci.yml

@@ -123,47 +123,64 @@ jobs:
     strategy:
       fail-fast: false # cancel all jobs as soon as one fails?
       matrix:
+        # Naming: {os}[-{runtimeVersion}]-{apiVersion}
+        # runtimeVersion = version of Godot binary; apiVersion = version of GDExtension API against which gdext is compiled.
+
         # Order this way because macOS typically has the longest duration, followed by Windows, so it benefits total workflow execution time.
         # Additionally, the 'linux (msrv *)' special case will then be listed next to the other 'linux' jobs.
         # Note: Windows uses '--target x86_64-pc-windows-msvc' by default as Cargo argument.
         include:
           # macOS
 
+          - name: macos-stableRt-4.0.3
+            os: macos-12
+            artifact-name: macos-stable
+            godot-binary: godot.macos.editor.dev.x86_64
+            godot-prebuilt-patch: '4.0.3'
+
           - name: macos-4.0.3
             os: macos-12
-            artifact-name: macos
+            artifact-name: macos-nightly
             godot-binary: godot.macos.editor.dev.x86_64
             godot-prebuilt-patch: '4.0.3'
 
           - name: macos-double
             os: macos-12
+            artifact-name: macos-double-nightly
             godot-binary: godot.macos.editor.dev.double.x86_64
             rust-extra-args: --features godot/double-precision
 
           - name: macos-nightly
             os: macos-12
-            artifact-name: macos
+            artifact-name: macos-nightly
             godot-binary: godot.macos.editor.dev.x86_64
             rust-extra-args: --features godot/custom-godot
             with-llvm: true
             godot-prebuilt-patch: '4.1'
 
           # Windows
 
+          - name: windows-stableRt-4.0.3
+            os: windows-latest
+            artifact-name: windows-stable
+            godot-binary: godot.windows.editor.dev.x86_64.exe
+            godot-prebuilt-patch: '4.0.3'
+
           - name: windows-4.0.3
             os: windows-latest
-            artifact-name: windows
+            artifact-name: windows-nightly
             godot-binary: godot.windows.editor.dev.x86_64.exe
             godot-prebuilt-patch: '4.0.3'
 
           - name: windows-double
             os: windows-latest
+            artifact-name: windows-double-nightly
             godot-binary: godot.windows.editor.dev.double.x86_64.exe
             rust-extra-args: --features godot/double-precision
 
           - name: windows-nightly
             os: windows-latest
-            artifact-name: windows
+            artifact-name: windows-nightly
             godot-binary: godot.windows.editor.dev.x86_64.exe
             rust-extra-args: --features godot/custom-godot
             godot-prebuilt-patch: '4.1'
@@ -172,44 +189,50 @@ jobs:
 
           # Don't use latest Ubuntu (22.04) as it breaks lots of ecosystem compatibility.
           # If ever moving to ubuntu-latest, need to manually install libtinfo5 for LLVM.
+          - name: linux-stableRt-4.0.3
+            os: ubuntu-20.04
+            artifact-name: linux-stable
+            godot-binary: godot.linuxbsd.editor.dev.x86_64
+
           - name: linux-4.0.3
             os: ubuntu-20.04
-            artifact-name: linux
+            artifact-name: linux-nightly
             godot-binary: godot.linuxbsd.editor.dev.x86_64
             godot-check-header: false # disabled for now
 
           - name: linux-4.0.2
             os: ubuntu-20.04
-            artifact-name: linux
+            artifact-name: linux-nightly
             godot-binary: godot.linuxbsd.editor.dev.x86_64
             godot-prebuilt-patch: '4.0.2'
 
           - name: linux-4.0.1
             os: ubuntu-20.04
-            artifact-name: linux
+            artifact-name: linux-nightly
             godot-binary: godot.linuxbsd.editor.dev.x86_64
             godot-prebuilt-patch: '4.0.1'
 
           - name: linux-4.0
             os: ubuntu-20.04
-            artifact-name: linux
+            artifact-name: linux-nightly
             godot-binary: godot.linuxbsd.editor.dev.x86_64
             godot-prebuilt-patch: '4.0'
 
           - name: linux-double
             os: ubuntu-20.04
+            artifact-name: linux-double-nightly
             godot-binary: godot.linuxbsd.editor.dev.double.x86_64
             rust-extra-args: --features godot/double-precision
 
           - name: linux-features
             os: ubuntu-20.04
-            artifact-name: linux
+            artifact-name: linux-nightly
             godot-binary: godot.linuxbsd.editor.dev.x86_64
             rust-extra-args: --features godot/threads,godot/serde
 
           - name: linux-nightly
             os: ubuntu-20.04
-            artifact-name: linux
+            artifact-name: linux-nightly
             godot-binary: godot.linuxbsd.editor.dev.x86_64
             rust-extra-args: --features godot/custom-godot
             godot-prebuilt-patch: '4.1'
@@ -220,35 +243,26 @@ jobs:
           # The gcc version can possibly be removed later, as it is slower and needs a larger artifact than the clang one.
 
           # --disallow-focus: fail if #[itest(focus)] is encountered, to prevent running only a few tests for full CI
-          - name: linux-memcheck-gcc-4.0.3
-            os: ubuntu-20.04
-            artifact-name: linux-memcheck-gcc
-            godot-binary: godot.linuxbsd.editor.dev.x86_64.san
-            godot-args: -- --disallow-focus
-            rust-toolchain: nightly
-            rust-env-rustflags: -Zrandomize-layout
 
-          - name: linux-memcheck-clang-4.0.3
+          - name: linux-memcheck-stable-4.0.3
             os: ubuntu-20.04
-            artifact-name: linux-memcheck-clang
+            artifact-name: linux-memcheck-clang-nightly
             godot-binary: godot.linuxbsd.editor.dev.x86_64.llvm.san
             godot-args: -- --disallow-focus
             rust-toolchain: nightly
             rust-env-rustflags: -Zrandomize-layout
 
-          - name: linux-memcheck-gcc-nightly
+          - name: linux-memcheck-4.0.3
             os: ubuntu-20.04
-            artifact-name: linux-memcheck-gcc
-            godot-binary: godot.linuxbsd.editor.dev.x86_64.san
+            artifact-name: linux-memcheck-clang-stable
+            godot-binary: godot.linuxbsd.editor.dev.x86_64.llvm.san
             godot-args: -- --disallow-focus
             rust-toolchain: nightly
             rust-env-rustflags: -Zrandomize-layout
-            rust-extra-args: --features godot/custom-godot
-            godot-prebuilt-patch: '4.1'
 
-          - name: linux-memcheck-clang-nightly
+          - name: linux-memcheck-nightly
             os: ubuntu-20.04
-            artifact-name: linux-memcheck-clang
+            artifact-name: linux-memcheck-clang-nightly
             godot-binary: godot.linuxbsd.editor.dev.x86_64.llvm.san
             godot-args: -- --disallow-focus
             rust-toolchain: nightly
@@ -263,7 +277,7 @@ jobs:
       - name: "Run Godot integration test"
         uses: ./.github/composite/godot-itest
         with:
-          artifact-name: godot-${{ matrix.artifact-name || matrix.name }}
+          artifact-name: godot-${{ matrix.artifact-name }}
           godot-binary: ${{ matrix.godot-binary }}
           godot-args: ${{ matrix.godot-args }}
           godot-prebuilt-patch: ${{ matrix.godot-prebuilt-patch }}