Merge pull request #1055 from Yarwin/fix-clippy

Fix clippy: operator precedence can trip the unwary.

Author: Bromeon

.github/workflows/full-ci.yml

@@ -103,6 +103,7 @@ jobs:
 
       # Note: could use `-- --no-deps` to not lint dependencies, however it doesn't really speed up and also skips deps in workspace.
       - name: "Check clippy"
+        # TODO(Rust 1.86): remove -A clippy::precedence; see https://github.com/godot-rust/gdext/pull/1055.
         run: |
           cargo clippy --all-targets $CLIPPY_FEATURES -- \
           -D clippy::suspicious \
@@ -112,7 +113,8 @@ jobs:
           -D clippy::dbg_macro \
           -D clippy::todo \
           -D clippy::unimplemented \
-          -D warnings
+          -D warnings \
+          -A clippy::precedence
 
   unit-test:
     name: unit-test (${{ matrix.name }}${{ matrix.rust-special }})

.github/workflows/minimal-ci.yml

@@ -96,6 +96,7 @@ jobs:
           components: clippy
 
       - name: "Check clippy"
+        # TODO(Rust 1.86): remove -A clippy::precedence; see https://github.com/godot-rust/gdext/pull/1055.
         run: |
           cargo clippy --all-targets $CLIPPY_FEATURES -- \
           -D clippy::suspicious \
@@ -105,7 +106,8 @@ jobs:
           -D clippy::dbg_macro \
           -D clippy::todo \
           -D clippy::unimplemented \
-          -D warnings
+          -D warnings \
+          -A clippy::precedence
           
 
   unit-test:

.github/workflows/release-version.yml

@@ -133,7 +133,8 @@ jobs:
           -D clippy::dbg_macro \
           -D clippy::todo \
           -D clippy::unimplemented \
-          -D warnings
+          -D warnings \
+          -A clippy::precedence
 
   rustfmt:
     runs-on: ubuntu-latest

check.sh

@@ -146,6 +146,12 @@ function cmd_fmt() {
 }
 
 function cmd_clippy() {
+    # TODO(Rust 1.86): remove `-A clippy::precedence`.
+    # In Rust 1.85, `clippy::precedence` includes bitmasking and shift operations. Rigid adherence to this rule results in more noisy code, with
+    # little benefits (being aware of bit operator precedence is something we can expect + bit manipulations are common in Godot).
+    # This behavior will be reverted in 1.86 and moved into new lint `precedence_bits` included in `restriction` category.
+    # See https://github.com/godot-rust/gdext/pull/1055 and https://github.com/rust-lang/rust-clippy/pull/14115.
+
     run cargo clippy --all-targets "${extraCargoArgs[@]}" -- \
         -D clippy::suspicious \
         -D clippy::style \
@@ -154,7 +160,8 @@ function cmd_clippy() {
         -D clippy::dbg_macro \
         -D clippy::todo \
         -D clippy::unimplemented \
-        -D warnings
+        -D warnings \
+        -A clippy::precedence
 }
 
 function cmd_klippy() {