Skip to content

Commit 36b0b6a

Browse files
authored
TWEAK: Make Runner interface public (#246)
1 parent 51825a3 commit 36b0b6a

File tree

5 files changed

+33
-33
lines changed

5 files changed

+33
-33
lines changed

dbr.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -99,13 +99,13 @@ type SessionRunner interface {
9999
DeleteBySql(query string, value ...interface{}) *DeleteBuilder
100100
}
101101

102-
type runner interface {
102+
type Runner interface {
103103
GetTimeout() time.Duration
104104
ExecContext(ctx context.Context, query string, args ...interface{}) (sql.Result, error)
105105
QueryContext(ctx context.Context, query string, args ...interface{}) (*sql.Rows, error)
106106
}
107107

108-
func exec(ctx context.Context, runner runner, log EventReceiver, builder Builder, d Dialect) (sql.Result, error) {
108+
func exec(ctx context.Context, runner Runner, log EventReceiver, builder Builder, d Dialect) (sql.Result, error) {
109109
timeout := runner.GetTimeout()
110110
if timeout > 0 {
111111
var cancel func()
@@ -152,7 +152,7 @@ func exec(ctx context.Context, runner runner, log EventReceiver, builder Builder
152152
return result, nil
153153
}
154154

155-
func queryRows(ctx context.Context, runner runner, log EventReceiver, builder Builder, d Dialect) (string, *sql.Rows, error) {
155+
func queryRows(ctx context.Context, runner Runner, log EventReceiver, builder Builder, d Dialect) (string, *sql.Rows, error) {
156156
// discard the timeout set in the runner, the context should not be canceled
157157
// implicitly here but explicitly by the caller since the returned *sql.Rows
158158
// may still listening to the context
@@ -196,7 +196,7 @@ func queryRows(ctx context.Context, runner runner, log EventReceiver, builder Bu
196196
return query, rows, nil
197197
}
198198

199-
func query(ctx context.Context, runner runner, log EventReceiver, builder Builder, d Dialect, dest interface{}) (int, error) {
199+
func query(ctx context.Context, runner Runner, log EventReceiver, builder Builder, d Dialect, dest interface{}) (int, error) {
200200
timeout := runner.GetTimeout()
201201
if timeout > 0 {
202202
var cancel func()

delete.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88

99
// DeleteStmt builds `DELETE ...`.
1010
type DeleteStmt struct {
11-
runner
11+
Runner
1212
EventReceiver
1313
Dialect
1414

@@ -65,7 +65,7 @@ func DeleteFrom(table string) *DeleteStmt {
6565
// DeleteFrom creates a DeleteStmt.
6666
func (sess *Session) DeleteFrom(table string) *DeleteStmt {
6767
b := DeleteFrom(table)
68-
b.runner = sess
68+
b.Runner = sess
6969
b.EventReceiver = sess.EventReceiver
7070
b.Dialect = sess.Dialect
7171
return b
@@ -74,7 +74,7 @@ func (sess *Session) DeleteFrom(table string) *DeleteStmt {
7474
// DeleteFrom creates a DeleteStmt.
7575
func (tx *Tx) DeleteFrom(table string) *DeleteStmt {
7676
b := DeleteFrom(table)
77-
b.runner = tx
77+
b.Runner = tx
7878
b.EventReceiver = tx.EventReceiver
7979
b.Dialect = tx.Dialect
8080
return b
@@ -94,7 +94,7 @@ func DeleteBySql(query string, value ...interface{}) *DeleteStmt {
9494
// DeleteBySql creates a DeleteStmt from raw query.
9595
func (sess *Session) DeleteBySql(query string, value ...interface{}) *DeleteStmt {
9696
b := DeleteBySql(query, value...)
97-
b.runner = sess
97+
b.Runner = sess
9898
b.EventReceiver = sess.EventReceiver
9999
b.Dialect = sess.Dialect
100100
return b
@@ -103,7 +103,7 @@ func (sess *Session) DeleteBySql(query string, value ...interface{}) *DeleteStmt
103103
// DeleteBySql creates a DeleteStmt from raw query.
104104
func (tx *Tx) DeleteBySql(query string, value ...interface{}) *DeleteStmt {
105105
b := DeleteBySql(query, value...)
106-
b.runner = tx
106+
b.Runner = tx
107107
b.EventReceiver = tx.EventReceiver
108108
b.Dialect = tx.Dialect
109109
return b
@@ -136,5 +136,5 @@ func (b *DeleteStmt) Exec() (sql.Result, error) {
136136
}
137137

138138
func (b *DeleteStmt) ExecContext(ctx context.Context) (sql.Result, error) {
139-
return exec(ctx, b.runner, b.EventReceiver, b, b.Dialect)
139+
return exec(ctx, b.Runner, b.EventReceiver, b, b.Dialect)
140140
}

insert.go

+7-7
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111

1212
// InsertStmt builds `INSERT INTO ...`.
1313
type InsertStmt struct {
14-
runner
14+
Runner
1515
EventReceiver
1616
Dialect
1717

@@ -113,7 +113,7 @@ func InsertInto(table string) *InsertStmt {
113113
// InsertInto creates an InsertStmt.
114114
func (sess *Session) InsertInto(table string) *InsertStmt {
115115
b := InsertInto(table)
116-
b.runner = sess
116+
b.Runner = sess
117117
b.EventReceiver = sess.EventReceiver
118118
b.Dialect = sess.Dialect
119119
return b
@@ -122,7 +122,7 @@ func (sess *Session) InsertInto(table string) *InsertStmt {
122122
// InsertInto creates an InsertStmt.
123123
func (tx *Tx) InsertInto(table string) *InsertStmt {
124124
b := InsertInto(table)
125-
b.runner = tx
125+
b.Runner = tx
126126
b.EventReceiver = tx.EventReceiver
127127
b.Dialect = tx.Dialect
128128
return b
@@ -141,7 +141,7 @@ func InsertBySql(query string, value ...interface{}) *InsertStmt {
141141
// InsertBySql creates an InsertStmt from raw query.
142142
func (sess *Session) InsertBySql(query string, value ...interface{}) *InsertStmt {
143143
b := InsertBySql(query, value...)
144-
b.runner = sess
144+
b.Runner = sess
145145
b.EventReceiver = sess.EventReceiver
146146
b.Dialect = sess.Dialect
147147
return b
@@ -150,7 +150,7 @@ func (sess *Session) InsertBySql(query string, value ...interface{}) *InsertStmt
150150
// InsertBySql creates an InsertStmt from raw query.
151151
func (tx *Tx) InsertBySql(query string, value ...interface{}) *InsertStmt {
152152
b := InsertBySql(query, value...)
153-
b.runner = tx
153+
b.Runner = tx
154154
b.EventReceiver = tx.EventReceiver
155155
b.Dialect = tx.Dialect
156156
return b
@@ -239,7 +239,7 @@ func (b *InsertStmt) Exec() (sql.Result, error) {
239239
}
240240

241241
func (b *InsertStmt) ExecContext(ctx context.Context) (sql.Result, error) {
242-
result, err := exec(ctx, b.runner, b.EventReceiver, b, b.Dialect)
242+
result, err := exec(ctx, b.Runner, b.EventReceiver, b, b.Dialect)
243243
if err != nil {
244244
return nil, err
245245
}
@@ -255,7 +255,7 @@ func (b *InsertStmt) ExecContext(ctx context.Context) (sql.Result, error) {
255255
}
256256

257257
func (b *InsertStmt) LoadContext(ctx context.Context, value interface{}) error {
258-
_, err := query(ctx, b.runner, b.EventReceiver, b, b.Dialect, value)
258+
_, err := query(ctx, b.Runner, b.EventReceiver, b, b.Dialect, value)
259259
return err
260260
}
261261

select.go

+9-9
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import (
1010

1111
// SelectStmt builds `SELECT ...`.
1212
type SelectStmt struct {
13-
runner
13+
Runner
1414
EventReceiver
1515
Dialect
1616

@@ -225,7 +225,7 @@ func prepareSelect(a []string) []interface{} {
225225
// Select creates a SelectStmt.
226226
func (sess *Session) Select(column ...string) *SelectStmt {
227227
b := Select(prepareSelect(column)...)
228-
b.runner = sess
228+
b.Runner = sess
229229
b.EventReceiver = sess.EventReceiver
230230
b.Dialect = sess.Dialect
231231
return b
@@ -234,7 +234,7 @@ func (sess *Session) Select(column ...string) *SelectStmt {
234234
// Select creates a SelectStmt.
235235
func (tx *Tx) Select(column ...string) *SelectStmt {
236236
b := Select(prepareSelect(column)...)
237-
b.runner = tx
237+
b.Runner = tx
238238
b.EventReceiver = tx.EventReceiver
239239
b.Dialect = tx.Dialect
240240
return b
@@ -255,7 +255,7 @@ func SelectBySql(query string, value ...interface{}) *SelectStmt {
255255
// SelectBySql creates a SelectStmt from raw query.
256256
func (sess *Session) SelectBySql(query string, value ...interface{}) *SelectStmt {
257257
b := SelectBySql(query, value...)
258-
b.runner = sess
258+
b.Runner = sess
259259
b.EventReceiver = sess.EventReceiver
260260
b.Dialect = sess.Dialect
261261
return b
@@ -264,7 +264,7 @@ func (sess *Session) SelectBySql(query string, value ...interface{}) *SelectStmt
264264
// SelectBySql creates a SelectStmt from raw query.
265265
func (tx *Tx) SelectBySql(query string, value ...interface{}) *SelectStmt {
266266
b := SelectBySql(query, value...)
267-
b.runner = tx
267+
b.Runner = tx
268268
b.EventReceiver = tx.EventReceiver
269269
b.Dialect = tx.Dialect
270270
return b
@@ -407,12 +407,12 @@ func (b *SelectStmt) Rows() (*sql.Rows, error) {
407407
}
408408

409409
func (b *SelectStmt) RowsContext(ctx context.Context) (*sql.Rows, error) {
410-
_, rows, err := queryRows(ctx, b.runner, b.EventReceiver, b, b.Dialect)
410+
_, rows, err := queryRows(ctx, b.Runner, b.EventReceiver, b, b.Dialect)
411411
return rows, err
412412
}
413413

414414
func (b *SelectStmt) LoadOneContext(ctx context.Context, value interface{}) error {
415-
count, err := query(ctx, b.runner, b.EventReceiver, b, b.Dialect, value)
415+
count, err := query(ctx, b.Runner, b.EventReceiver, b, b.Dialect, value)
416416
if err != nil {
417417
return err
418418
}
@@ -431,7 +431,7 @@ func (b *SelectStmt) LoadOne(value interface{}) error {
431431
}
432432

433433
func (b *SelectStmt) LoadContext(ctx context.Context, value interface{}) (int, error) {
434-
return query(ctx, b.runner, b.EventReceiver, b, b.Dialect, value)
434+
return query(ctx, b.Runner, b.EventReceiver, b, b.Dialect, value)
435435
}
436436

437437
// Load loads multi-row SQL result into a slice of go variables.
@@ -448,7 +448,7 @@ func (b *SelectStmt) Iterate() (Iterator, error) {
448448

449449
// IterateContext executes the query and returns the Iterator, or any error encountered.
450450
func (b *SelectStmt) IterateContext(ctx context.Context) (Iterator, error) {
451-
_, rows, err := queryRows(ctx, b.runner, b.EventReceiver, b, b.Dialect)
451+
_, rows, err := queryRows(ctx, b.Runner, b.EventReceiver, b, b.Dialect)
452452
if err != nil {
453453
if rows != nil {
454454
rows.Close()

update.go

+7-7
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88

99
// UpdateStmt builds `UPDATE ...`.
1010
type UpdateStmt struct {
11-
runner
11+
Runner
1212
EventReceiver
1313
Dialect
1414

@@ -105,7 +105,7 @@ func Update(table string) *UpdateStmt {
105105
// Update creates an UpdateStmt.
106106
func (sess *Session) Update(table string) *UpdateStmt {
107107
b := Update(table)
108-
b.runner = sess
108+
b.Runner = sess
109109
b.EventReceiver = sess.EventReceiver
110110
b.Dialect = sess.Dialect
111111
return b
@@ -114,7 +114,7 @@ func (sess *Session) Update(table string) *UpdateStmt {
114114
// Update creates an UpdateStmt.
115115
func (tx *Tx) Update(table string) *UpdateStmt {
116116
b := Update(table)
117-
b.runner = tx
117+
b.Runner = tx
118118
b.EventReceiver = tx.EventReceiver
119119
b.Dialect = tx.Dialect
120120
return b
@@ -135,7 +135,7 @@ func UpdateBySql(query string, value ...interface{}) *UpdateStmt {
135135
// UpdateBySql creates an UpdateStmt with raw query.
136136
func (sess *Session) UpdateBySql(query string, value ...interface{}) *UpdateStmt {
137137
b := UpdateBySql(query, value...)
138-
b.runner = sess
138+
b.Runner = sess
139139
b.EventReceiver = sess.EventReceiver
140140
b.Dialect = sess.Dialect
141141
return b
@@ -144,7 +144,7 @@ func (sess *Session) UpdateBySql(query string, value ...interface{}) *UpdateStmt
144144
// UpdateBySql creates an UpdateStmt with raw query.
145145
func (tx *Tx) UpdateBySql(query string, value ...interface{}) *UpdateStmt {
146146
b := UpdateBySql(query, value...)
147-
b.runner = tx
147+
b.Runner = tx
148148
b.EventReceiver = tx.EventReceiver
149149
b.Dialect = tx.Dialect
150150
return b
@@ -209,11 +209,11 @@ func (b *UpdateStmt) Exec() (sql.Result, error) {
209209
}
210210

211211
func (b *UpdateStmt) ExecContext(ctx context.Context) (sql.Result, error) {
212-
return exec(ctx, b.runner, b.EventReceiver, b, b.Dialect)
212+
return exec(ctx, b.Runner, b.EventReceiver, b, b.Dialect)
213213
}
214214

215215
func (b *UpdateStmt) LoadContext(ctx context.Context, value interface{}) error {
216-
_, err := query(ctx, b.runner, b.EventReceiver, b, b.Dialect, value)
216+
_, err := query(ctx, b.Runner, b.EventReceiver, b, b.Dialect, value)
217217
return err
218218
}
219219

0 commit comments

Comments
 (0)