Merge pull request #43 from go-playground/bb-uuid-check-enhancement

Dean Karn · web-flow · commit a610eb250e20 · 2018-08-09T12:28:51.000-07:00
only validate UUID header when expecting one
diff --git a/bitbucket/bitbucket.go b/bitbucket/bitbucket.go
@@ -93,7 +93,7 @@ func (hook Webhook) Parse(r *http.Request, events ...Event) (interface{}, error)
 	}
 
 	uuid := r.Header.Get("X-Hook-UUID")
-	if uuid == "" {
+	if hook.uuid != "" && uuid == "" {
 		return nil, ErrMissingHookUUIDHeader
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ func (hook Webhook) Parse(r *http.Request, events ...Event) (interface{}, error)`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`uuid := r.Header.Get("X-Hook-UUID")`
`96`		`- if uuid == "" {`
	`96`	`+ if hook.uuid != "" && uuid == "" {`
`97`	`97`	`return nil, ErrMissingHookUUIDHeader`
`98`	`98`	`}`
`99`	`99`