Import package only if expression will be resolved afterwards

[dlsniper]

• Plugin version (or commit hash): 0.11.1273

Given the following example:

package main

func main() {
    demopack.Demo
}

If in the GOPATH there's a package called demopack then it will be added automatically to the import list. However, the if the package doesn't contain any Demo definition then the unresolved expression will now shift from the demopack to Demo.
If possible, I propose the following rules:

if package name name matches the first part of the expression then
  check if the second part is defined in the said package
  if defined then import else
    if package is in current project then
      import package
    else skip
else skip

The reason I'm suggesting to still allow for importing the package if it's in the current project is that we can then later provide a quickfix to say: create (variable/conf/struct/interface) in package
Does it make sense?

[zolotov]

#1730?

[dlsniper]

Hmm, that's related but I don't know if it's the same or not. Right now the problem I'm facing is that the import kicks in automatically regardless of what action I do in the code (I guess I only have a package named demopack in my GOPATH).

[zolotov]

Right now the problem I'm facing is that the import kicks in automatically regardless of what action I do in the code (I guess I only have a package named demopack in my GOPATH).

Since you have no any other demopack packages in our GOPATH then why not?

[dlsniper]

Since you have no any other demopack packages in our GOPATH then why not?

There could be a few reasons why this is not the desired effect.
It could be that I'd rather create a struct / interface to handle this than import a package. Another reason could be that the package is not in the current project and I cannot or don't want to edit that package. Finally, because importing it will still not fix the issue of unresolved reference, just shift it from a place to another.

[zolotov]

Finally, because importing it will still not fix the issue of unresolved reference, just shift it from a place to another.

This is covered by #1730

It could be that I'd rather create a struct / interface to handle this than import a package.

Good point, will think what we can do