One line feed is lost in the tests output #1481

Author: zolotov

src/com/goide/runconfig/testing/GoTestConsoleProperties.java

@@ -64,6 +64,7 @@ public static class GoOutputToGeneralTestEventsConverter extends OutputToGeneral
 
     private boolean myFailed = false;
     private boolean mySkipped = false;
+    private boolean myOutputAppeared = false;
     @NotNull private StringBuilder myStdOut = new StringBuilder();
     @NotNull private String myCurrentTest = "<test>";
 
@@ -77,16 +78,18 @@ protected boolean processServiceMessages(@NotNull String text, Key outputType, S
       Matcher matcher;
 
       if ((matcher = RUN.matcher(text)).find()) {
+        myOutputAppeared = false;
         String testName = StringUtil.notNullize(matcher.group(1), "<test>");
         ServiceMessageBuilder testStarted = ServiceMessageBuilder.testStarted(testName).addAttribute("locationHint", testUrl(testName));
         return processNotFinishedMessage(testStarted.toString(), outputType, visitor);
       }
 
       if ((matcher = PASSED.matcher(text)).find()) {
         String testName = StringUtil.notNullize(matcher.group(1), "<test>");
-        return processNotFinishedMessage(ServiceMessageBuilder.testFinished(testName).toString(), outputType, visitor);
+        return addNewLineIfNeeded(testName, outputType, visitor) 
+               && processNotFinishedMessage(ServiceMessageBuilder.testFinished(testName).toString(), outputType, visitor);
       }
-      
+
       if ((matcher = SKIP.matcher(text)).find()) {
         mySkipped = true;
         myCurrentTest = StringUtil.notNullize(matcher.group(1), "<test>");
@@ -109,6 +112,7 @@ protected boolean processServiceMessages(@NotNull String text, Key outputType, S
         }
       }
 
+      myOutputAppeared = true;
       return super.processServiceMessages(text, outputType, visitor);
     }
 
@@ -125,16 +129,22 @@ private boolean processNotFinishedMessage(String message, Key outputType, Servic
     }
 
     private boolean processFailedMessage(Key outputType, ServiceMessageVisitor visitor) throws ParseException {
-      ServiceMessageBuilder builder = myFailed 
-                                      ? ServiceMessageBuilder.testFailed(myCurrentTest) 
+      ServiceMessageBuilder builder = myFailed
+                                      ? ServiceMessageBuilder.testFailed(myCurrentTest)
                                       : ServiceMessageBuilder.testIgnored(myCurrentTest);
       String message = builder.addAttribute("message", myStdOut.toString().trim()).toString();
-      
+
       myFailed = false;
       mySkipped = false;
       myStdOut = new StringBuilder();
       return super.processServiceMessages(message, outputType, visitor)
              && super.processServiceMessages(ServiceMessageBuilder.testFinished(myCurrentTest).toString(), outputType, visitor);
     }
+
+    private boolean addNewLineIfNeeded(@NotNull String testName, @NotNull Key outputType, @NotNull ServiceMessageVisitor visitor)
+      throws ParseException {
+      ServiceMessageBuilder message = ServiceMessageBuilder.testStdOut(testName).addAttribute("out", "\n");
+      return !myOutputAppeared || processServiceMessages(message.toString(), outputType, visitor);
+    }
   }
 }

testData/testing/multipleTestsFailed-expected.txt

@@ -9,4 +9,4 @@ finished_test: TestSqrt
 started_test: TestSqrt2
   failed_test: TestSqrt2
     test_test.go:15: Sqrt(4) = 2, want 3
-finished_test: TestSqrt2
+finished_test: TestSqrt2

testData/testing/singleTestFailed-expected.txt

@@ -1,4 +1,4 @@
 started_test: TestSqrt2
   failed_test: TestSqrt2
     test_test.go:15: Sqrt(4) = 2, want 3
-finished_test: TestSqrt2
+finished_test: TestSqrt2

testData/testing/singleTestOk-expected.txt

@@ -1,2 +1,2 @@
 started_test: TestSqrt2
-finished_test: TestSqrt2
+finished_test: TestSqrt2

testData/testing/skipTest-expected.txt

@@ -5,4 +5,4 @@ started_test: TestRuntimeMemStatsBlocking
     runtime_test.go:20: skipping TestRuntimeMemStatsBlocking with GOMAXPROCS=1
 finished_test: TestRuntimeMemStatsBlocking
 started_test: TestExpDecaySample10
-finished_test: TestExpDecaySample10
+finished_test: TestExpDecaySample10

testData/testing/stdOut-expected.txt

@@ -0,0 +1,12 @@
+started_test: TestEWMA1
+  test_output
+
+finished_test: TestEWMA1
+started_test: TestEWMA5
+  failed_test: TestEWMA5
+    ewma_test.go:122: 6 minute a.Rate(): 0.18071652714732128 != 0.18071652714732128
+finished_test: TestEWMA5
+started_test: TestEWMA15
+  test_output
+
+finished_test: TestEWMA15

testData/testing/stdOut.txt

@@ -0,0 +1,17 @@
+=== RUN TestEWMA1
+hello
+hello
+
+--- PASS: TestEWMA1 (0.00 seconds)
+=== RUN TestEWMA5
+hello2
+hello2
+
+--- FAIL: TestEWMA5 (0.00 seconds)
+	ewma_test.go:122: 6 minute a.Rate(): 0.18071652714732128 != 0.18071652714732128
+=== RUN TestEWMA15
+hello3
+hello3
+--- PASS: TestEWMA15 (0.00 seconds)
+FAIL
+exit status 1

tests/com/goide/runconfig/testing/GoUnitTestEventsConverterTest.java

@@ -33,6 +33,10 @@ public void testMultipleTestsOk() throws Exception {
   public void testSkipTest() throws Exception {
     doTest();
   }
+  
+  public void testStdOut() throws Exception {
+    doTest();
+  }
 
   @Override
   protected String getBasePath() {