PG index options handle CONCURRENT option separately (#297)

abbyssoul · web-flow · commit 04418c920c1f · 2025-03-10T10:25:04.000+08:00
diff --git a/migrator.go b/migrator.go
@@ -130,7 +130,8 @@ func (m Migrator) CreateIndex(value interface{}, name string) error {
 				}
 				createIndexSQL += "INDEX "
 
-				if strings.TrimSpace(strings.ToUpper(idx.Option)) == "CONCURRENTLY" {
+				hasConcurrentOption := strings.TrimSpace(strings.ToUpper(idx.Option)) == "CONCURRENTLY"
+				if hasConcurrentOption {
 					createIndexSQL += "CONCURRENTLY "
 				}
 
@@ -142,7 +143,7 @@ func (m Migrator) CreateIndex(value interface{}, name string) error {
 					createIndexSQL += " ?"
 				}
 
-				if idx.Option != "" && strings.TrimSpace(strings.ToUpper(idx.Option)) != "CONCURRENTLY" {
+				if idx.Option != "" && !hasConcurrentOption {
 					createIndexSQL += " " + idx.Option
 				}
 

Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,8 @@ func (m Migrator) CreateIndex(value interface{}, name string) error {`
`130`	`130`	`}`
`131`	`131`	`createIndexSQL += "INDEX "`
`132`	`132`
`133`		`- if strings.TrimSpace(strings.ToUpper(idx.Option)) == "CONCURRENTLY" {`
	`133`	`+ hasConcurrentOption := strings.TrimSpace(strings.ToUpper(idx.Option)) == "CONCURRENTLY"`
	`134`	`+ if hasConcurrentOption {`
`134`	`135`	`createIndexSQL += "CONCURRENTLY "`
`135`	`136`	`}`
`136`	`137`
`@@ -142,7 +143,7 @@ func (m Migrator) CreateIndex(value interface{}, name string) error {`
`142`	`143`	`createIndexSQL += " ?"`
`143`	`144`	`}`
`144`	`145`
`145`		`- if idx.Option != "" && strings.TrimSpace(strings.ToUpper(idx.Option)) != "CONCURRENTLY" {`
	`146`	`+ if idx.Option != "" && !hasConcurrentOption {`
`146`	`147`	`createIndexSQL += " " + idx.Option`
`147`	`148`	`}`
`148`	`149`