Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP_DATA_PATH vs WORK_PATH #33157

Closed
ghnp5 opened this issue Jan 9, 2025 · 5 comments
Closed

APP_DATA_PATH vs WORK_PATH #33157

ghnp5 opened this issue Jan 9, 2025 · 5 comments
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail

Comments

@ghnp5
Copy link

ghnp5 commented Jan 9, 2025

Hello.
I've just realized that I have these two configs the same:

WORK_PATH = /data/gitea
APP_DATA_PATH = /data/gitea

When reviewing the example app.example.ini, I see that APP_DATA_PATH should have its own dedicated folder.

Is there a risk in having both of these the same? Like, if there are directories with the same name that could conflict with each other?

If I want to move APP_DATA_PATH to its own directory, is there an easy way to know which subdirectories I need to move into that new APP_DATA_PATH?

Many thanks!

@ghnp5 ghnp5 added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Jan 9, 2025
@wxiaoguang
Copy link
Contributor

I think you are using docker, nothing need to do.

Is there a risk in having both of these the same?

At the moment, no, Gitea will do the best to avoid conflicting.

If I want to move APP_DATA_PATH to its own directory, is there an easy way to know which subdirectories I need to move into that new APP_DATA_PATH?

Not that easy.

@wxiaoguang wxiaoguang added issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail and removed type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Jan 9, 2025
@ghnp5
Copy link
Author

ghnp5 commented Jan 9, 2025

Thank you for your reply.

Yes - I'm using Docker. But in terms of filesystem structure, there is probably no much difference, so that's why I didn't mention it.

Not that easy.

Ah ok. If it was a matter of simply moving a number of folders to the new location, I'd be happy to do it.
However, if there are hardcoded locations in the database and other places, after the first run, then I understand why it may be hard.

Thank you again.

actions_artifacts
actions_log
attachments
avatars
conf
home
indexers
jwt
log
packages
queues
repo-archive
repo-avatars
tmp

@wxiaoguang
Copy link
Contributor

Not that easy.

Ah ok. If it was a matter of simply moving a number of folders to the new location, I'd be happy to do it. However, if there are hardcoded locations in the database and other places, after the first run, then I understand why it may be hard.

It's not worth to do that, and it would break the docker's default config (although the default config is not that right, since it has been widely used so it won't cause problem)

@wxiaoguang
Copy link
Contributor

I think this issue could be closed?

@ghnp5
Copy link
Author

ghnp5 commented Jan 10, 2025

Sure. I appreciate your replies. Thanks!

@ghnp5 ghnp5 closed this as completed Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail
Projects
None yet
Development

No branches or pull requests

2 participants