Skip to content

Display changes in PR since last review / since specified commit #20989

Closed
@Artalus

Description

@Artalus

Feature Description

GitHub and GitLab have this great feature which allows you to see exactly what have changed in the PR since the last time you've looked at it. In Gitea it seems that the only option currently is to view commits one be one.

A tiny step in that directions was made in PR #19007 though it only labels the files as "changed since" instead of providing the diff. Also there are issues #12800 and #19862 , which are more "generalized" versions of this feature request.

Screenshots

  • Github:
    image
  • Gitlab:
    image

Activity

added
type/featureCompletely new functionality. Can only be merged if feature freeze is not active.
type/proposalThe new feature has not been accepted yet but needs to be discussed first.
on Aug 29, 2022
thammaknot

thammaknot commented on Oct 18, 2022

@thammaknot

This feature would be awesome. I miss it moving from gitlab/github as well.
Thank you for proposing.

cy18

cy18 commented on Dec 19, 2022

@cy18

I'm missing this feature too. After migrating from gitlab to gitea for about one year, this is the only defect of gitea.

lunny

lunny commented on Dec 19, 2022

@lunny
Member

Maybe #13313 could fix this one?

Artalus

Artalus commented on Dec 19, 2022

@Artalus
Author

From the issues mentioned there, it seems that people do have a common need - to see what was updated in PR (whether force-push, amends and rebases are involved or not).

Given that Gitea already has an URL /compare/commitA...commitB, one could start from at least adding a user-friendly interface for that in PR page. However it is actually just a comparison of two arbitrary commits, and does not allow reviewing for example.

cy18

cy18 commented on Dec 20, 2022

@cy18

/compare/commitA...commitB

The /compare/commitA...commitB does not eliminate identical changes of the two commits.

sebastian-sauer

sebastian-sauer commented on Jul 6, 2023

@sebastian-sauer
Contributor

#25528 implements a first version of this commit selector

changes since last review could be a next PR

sebastian-sauer

sebastian-sauer commented on Jul 6, 2023

@sebastian-sauer
Contributor

Update: the display changes since last review is now implemented, too ;-)

locked as resolved and limited conversation to collaborators on Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type/featureCompletely new functionality. Can only be merged if feature freeze is not active.type/proposalThe new feature has not been accepted yet but needs to be discussed first.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @lunny@sebastian-sauer@thammaknot@Artalus@cy18

      Issue actions

        Display changes in PR since last review / since specified commit · Issue #20989 · go-gitea/gitea