Updated isDate() thanks to user foxbunny

Author: chriso

README.md

@@ -178,7 +178,7 @@ Validator.prototype.getErrors = function () {
 - [PING](https://github.com/PlNG) - Fixed entity encoding
 - [Dan VerWeire](https://github.com/wankdanker) - Modified the behaviour of the error handler
 - [ctavan](https://github.com/ctavan) - Added isArray and isUUID()
-- [foxbunny](https://github.com/foxbunny) - Added min() and max()
+- [foxbunny](https://github.com/foxbunny) - Added min() and max(), and improved isDate()
 - [oris](https://github.com/orls) - Addded in()
 
 ## LICENSE

lib/validator.js

@@ -191,22 +191,10 @@ Validator.prototype.isUUID = function(version) {
 }
 
 Validator.prototype.isDate = function() {
-    var pattern = /^([0-1]{0,1}[0-9]{1})\/([0-3]{0,1}[0-9]{1})\/([0-9]{4})$/;
-    var result = pattern.exec(this.str);
-
-    if (!result || result.length != 4 ) {
-        return this.error(this.msg || 'Not a date');
+    var intDate = Date.parse(this.str);
+    if (isNaN(intDate)) { 
+        return this.error(this.msg || 'Not a date'); 
     }
-
-    var dt = new Date(this.str);
-
-    if (   dt.getFullYear()  != parseInt(result[3])
-        || dt.getMonth() + 1 != parseInt(result[1])
-        || dt.getDate()      != parseInt(result[2])
-    ) {
-        return this.error(this.msg || 'Not a date');
-    }
-
     return this;
 }
 

test/validator.test.js

@@ -502,5 +502,18 @@ module.exports = {
             assert.ok(Validator.check(new Object()).isArray());
             assert.ok(false, 'len failed');
         } catch (e) {}
+    },
+
+    'test #isDate()': function() {
+        assert.ok(Validator.check('2011-08-04').isDate());
+        assert.ok(Validator.check('04. 08. 2011.').isDate());
+        assert.ok(Validator.check('08/04/2011').isDate());
+        assert.ok(Validator.check('2011.08.04').isDate());
+        assert.ok(Validator.check('4. 8. 2011. GMT').isDate());
+        assert.ok(Validator.check('2011-08-04 12:00').isDate());
+
+        assert.throws(Validator.check('foo').isDate);
+        assert.throws(Validator.check('2011-foo-04').isDate);
+        assert.throws(Validator.check('GMT').isDate);
     }
 }

validator-min.js

@@ -696,22 +696,10 @@
     }
 
     Validator.prototype.isDate = function() {
-        var pattern = /^([0-1]{0,1}[0-9]{1})\/([0-3]{0,1}[0-9]{1})\/([0-9]{4})$/;
-        var result = pattern.exec(this.str);
-
-        if (result.length != 4 ) {
-            return this.error(this.msg || 'Not a date');
+        var intDate = Date.parse(this.str);
+        if (isNaN(intDate)) { 
+            return this.error(this.msg || 'Not a date'); 
         }
-
-        var dt = new Date(this.str);
-
-        if (   dt.getFullYear()  != parseInt(result[3])
-            || dt.getMonth() + 1 != parseInt(result[1])
-            || dt.getDate()      != parseInt(result[2])
-        ) {
-            return this.error(this.msg || 'Not a date');
-        }
-
         return this;
     }