Fix up a few issues with hover data.

Author: Carifio24

glue_plotly/common/image.py

@@ -317,20 +317,19 @@ def traces_for_scatter_layer(viewer_state, layer_state, hover_data=None, add_dat
                   size=scatter_size_info(layer_state, mask),
                   sizemin=1)
 
-    if np.sum(hover_data) == 0:
+    if hover_data is None or np.sum(hover_data) == 0:
         hoverinfo = 'skip'
         hovertext = None
     else:
         hoverinfo = 'text'
         hovertext = ['' for _ in range(layer_state.layer.shape[0])]
-        for i in range(len(layer_state.layer.components)):
-            if hover_data[i]:
-                label = layer_state.layer.components[i].label
+        for component in layer_state.layer.components:
+            label = component.label
+            if hover_data.get(label, False):
                 hover_values = layer_state.layer[label][mask]
                 for k in range(len(hover_values)):
                     hovertext[k] = (hovertext[k] + '{}: {} <br>'
-                                    .format(layer_state.layer.components[i].label,
-                                            hover_values[k]))
+                                    .format(label, hover_values[k]))
 
     name = layer_state.layer.label
     if add_data_label and not isinstance(layer_state.layer, BaseData):

glue_plotly/common/scatter2d.py

@@ -303,8 +303,9 @@ def trace_data_for_layer(viewer, layer_state, hover_data=None, add_data_label=Tr
     else:
         hoverinfo = 'text'
         hovertext = ["" for _ in range(mask.size)]
-        for label in layer_state.layer.components:
-            if hover_data[label]:
+        for component in layer_state.layer.components:
+            label = component.label
+            if hover_data.get(label, False):
                 hover_values = layer_state.layer[label][mask]
                 for k in range(len(hover_values)):
                     hovertext[k] = (hovertext[k] + "{}: {} <br>"

glue_plotly/common/scatter3d.py

@@ -128,8 +128,9 @@ def traces_for_layer(viewer_state, layer_state, hover_data=None, add_data_label=
     else:
         hoverinfo = 'text'
         hovertext = ["" for _ in range(mask.size)]
-        for label in layer_state.layer.components:
-            if hover_data[label]:
+        for component in layer_state.layer.components:
+            label = component.label
+            if hover_data.get(label, False):
                 hover_values = layer_state.layer[label][mask]
                 for k in range(len(hover_values)):
                     hovertext[k] = (hovertext[k] + "{}: {} <br>"

glue_plotly/html_exporters/jupyter/save_hover.py

@@ -46,7 +46,8 @@ def _on_data_change(self, *args):
         ]
         current_selections = self.checked_dictionary.get(self.state.data.label,
                                                          {component.label: False for component in data_components})
-        self.component_selected = [i for i in range(len(data_components)) if current_selections[i]]
+        self.component_selected = [i for i, component in enumerate(data_components)
+                                   if current_selections[component.label]]
 
     @observe('component_selected')
     def _on_component_selected_changed(self, change):