Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idealized design of config #2

Open
progrium opened this issue Aug 30, 2017 · 4 comments
Open

idealized design of config #2

progrium opened this issue Aug 30, 2017 · 4 comments

Comments

@progrium
Copy link
Contributor

progrium commented Aug 30, 2017

Notes from our conversation on simplifying configuration to almost no (separate) configuration!

  • Make Let's Encrypt account email be set via environment variable
  • Specify in environment a secret name to be used to generate/persist a Let's Encrypt key
  • Put certificate domain(s) and certificate secret name in annotations of deployments (and potentially other resources types?)
  • Certs are stored as they are now in a TLS secret, with name specified by annotation
@progrium
Copy link
Contributor Author

progrium commented Aug 30, 2017

Quick thoughts while writing this up... if the deployment needs to mount the tls secret, but the secret is created by the certdaemon only after a deployment is made, is there a circular dependency there that might cause the deployment to fail or at best fail and retry until certdaemon does its thing?

@Omeryl
Copy link

Omeryl commented Aug 30, 2017

The deployment is configured, the Pod will pend waiting for the secret. Annotations on the deployment are still accessible.

@progrium
Copy link
Contributor Author

And this is only the first time you deploy. Once the tls secret is made, this problem goes away. Sounds reasonable, assuming pod will sit in pending until secret is made.

@Omeryl
Copy link

Omeryl commented Aug 30, 2017

Correct, it’ll go into backoff just like image pulling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants