Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfiles not exposing ports #150

Open
CVTJNII opened this issue Jan 9, 2017 · 0 comments
Open

Dockerfiles not exposing ports #150

CVTJNII opened this issue Jan 9, 2017 · 0 comments

Comments

@CVTJNII
Copy link

CVTJNII commented Jan 9, 2017

In the Legacy branch the dockerfiles used to expose the consul ports: https://github.com/gliderlabs/docker-consul/blob/legacy/Dockerfile#L31

This has been removed in the current Dockerfiles. Was there motivation for this or was it simply an oversight? I maintain a test suite that spins up ephemeral Consul containers to test API calls against and it's easier to map ports when they are exposed, so if this is simply an oversight I'll open a PR to add them back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant