Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated tests #9

Open
Alkarex opened this issue Nov 19, 2024 · 2 comments
Open

Add automated tests #9

Alkarex opened this issue Nov 19, 2024 · 2 comments

Comments

@Alkarex
Copy link

Alkarex commented Nov 19, 2024

Please consider adding some (automated) tests, in particular to ensure compatibility with FreshRSS.
See example
Joedmin/xExtension-wallabag-button#1

A little detail is that on the main extensions repo, this extension is generating a warning (due to a limitation of our test tools), which would be nice to get rid of:

------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 
  Line   third-party/8c042738017d75b31bcbc23d84cfb35d6315f3a7/comics/penny-arcade.php                                                                                                                                                        
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 
  :59    Inner named functions are not supported by PHPStan. Consider refactoring to an anonymous function, class method, or a top-level-defined function. See issue #165 (https://github.com/phpstan/phpstan/issues/165) for more details.  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 
@giventofly
Copy link
Owner

Hi,

I currently don't have time to implement tests, but will keep that in mind for the future. If anyone is reading this and wants to do a PR for this, I can merge it

@Alkarex
Copy link
Author

Alkarex commented Jan 16, 2025

FreshRSS/Extensions#248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants