Skip to content

Commit f62df52

Browse files
committed
Remove TestSubmodule.test_rename xfail mark
This is to clearly establish the failure still occurs (since we do not have strict=True set). It is in preparation for working around the problems with a call to gc.collect(). See 82c361e and 0b7ee17 for context.
1 parent 0fa0047 commit f62df52

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

Diff for: test/test_submodule.py

-12
Original file line numberDiff line numberDiff line change
@@ -948,18 +948,6 @@ def test_remove_norefs(self, rwdir):
948948
sm.remove()
949949
assert not sm.exists()
950950

951-
@pytest.mark.xfail(
952-
os.name == "nt" and sys.version_info >= (3, 12),
953-
reason=(
954-
"The sm.move call fails. Submodule.move calls os.renames, which raises:\n"
955-
"PermissionError: [WinError 32] "
956-
"The process cannot access the file because it is being used by another process: "
957-
R"'C:\Users\ek\AppData\Local\Temp\test_renamekkbznwjp\parent\mymodules\myname' "
958-
R"-> 'C:\Users\ek\AppData\Local\Temp\test_renamekkbznwjp\parent\renamed\myname'"
959-
"\nThis resembles other Windows errors, but only occurs starting in Python 3.12."
960-
),
961-
raises=PermissionError,
962-
)
963951
@with_rw_directory
964952
def test_rename(self, rwdir):
965953
parent = git.Repo.init(osp.join(rwdir, "parent"))

0 commit comments

Comments
 (0)