[code-desktop] stop the local app when uninstalling extension

[akosyakov]

The VSCode plugin for the local companion app / remote VSCode spawns a process that is not removed or cleaned up when the extension is subsequently uninstalled. Removal of the VSCode extension should also close the process.

[loujaybee]

For context, the original user feedback associated with this issue is:

The local companion doesn't seem to be removed when uninstalling the VSC extension.

I’m not sure I fully understand the feedback. As the VS Code Remote extension is a separate app / process to the companion app, so I don't think it makes sense for the two applications to be linked. For instance, a user may have the local companion app running for direct SSH access to their workspace, and not just for the VSCode extension.

Options/thoughts:

• Currently, since the app is distributed as the binary file, we could investigate making the app more visible to users, by having a menu bar app (on OSX) or something similar.
• Investigate methods of stopping the companion app, i.e after some amount of idle time.

EDIT: My fault, it seems this issue occurs during usage of the VSCode Extension, not the binary directly.

[akosyakov]

I’m not sure I fully understand the feedback. As the VS Code Remote extension is a separate app / process to the companion app, so I don't think it makes sense for the two applications to be linked. For instance, a user may have the local companion app running for direct SSH access to their workspace, and not just for the VSCode extension.

It is not really like that, sorry for confusion. VS Code Desktop is using own instance managed by Gitpod VS Code extension. It should not exist if Gitpod VS Code extension is uninstalled.

[akosyakov]

Investigate methods of stopping the companion app, i.e after some amount of idle time.

+1 This we should do.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[schickling]

Not stale.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[schickling]

Still not stale.